fix: preserve empty JSON schemas for tool parameters#21854
Open
fix: preserve empty JSON schemas for tool parameters#21854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MCP and dynamic tool schemas can use an empty JSON Schema object (
{}) to mean an unconstrained value. The tool schema sanitizer previously inferredstringwhen no schema keywords were present, which narrowed{}into{ "type": "string" }.That misrepresents schemas for tools such as Notion page creation, where fields like
body.parentmay be object-shaped payloads even when the upstream schema leaves the field unconstrained. Advertising those fields as strings gives the model and any downstream schema validation the wrong contract.What changed
sanitize_json_schemainstead of inferringstring.JsonSchema::anyconstructor for the internal unconstrained schema representation.{}and nested property schemas such asbody.parent: {}remain unconstrained.