daemon: refresh updater after validated binary rollout#21853
Open
euroelessar wants to merge 1 commit intomainfrom
Open
daemon: refresh updater after validated binary rollout#21853euroelessar wants to merge 1 commit intomainfrom
euroelessar wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
bootstrapstarts a detached pid-backed updater loop, but before this change that updater could keep running an old executable image even afterinstall.shreplaced the managed standalone binary underCODEX_HOME. That left the updater itself behind the binary it had just rolled out, especially when the app-server was stopped or when the managed binary changed without a version-string change.What changed
bootstrapcannot race the handoff.app-server-daemon/README.mdto document the resulting standalone and out-of-band update behavior.Verification
cargo test -p codex-app-server-daemonjust fix -p codex-app-server-daemonAdded focused unit coverage for: