Conversation
evawong-oai
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#21819 adds high-level coverage for sandboxed
apply_patchand sandboxedfs/writeFilebehavior around link aliases. This follow-up tests the lower-level macOS workspace-write sandbox directly so the boundary is explicit.The important distinction is that writing an existing hard link inside the writable workspace preserves normal filesystem semantics, but that is not an arbitrary-write primitive by itself: the sandbox rejects creating a new hard link to a file outside the workspace, and it rejects symlink write-through to an outside target.
What Changed
Added macOS-only
codex-execsandbox tests that verify workspace-write:Testing
cargo test -p codex-exec macos_workspace_writejust fix -p codex-execStack created with Sapling. Best reviewed with ReviewStack.