app-server: remove TCP websocket listener#21843
Open
euroelessar wants to merge 3 commits intomainfrom
Open
Conversation
owenlin0
approved these changes
May 8, 2026
euroelessar
added a commit
that referenced
this pull request
May 8, 2026
9eca469 to
410b777
Compare
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The app-server no longer needs to expose a TCP websocket listener. Keeping that transport also kept around a separate listener/auth surface that is unnecessary now that local clients can use stdio or the Unix-domain control socket, while remote connectivity is handled by
remote_control.What Changed
ws://IP:PORTparsing and theAppServerTransport::WebSocketstartup path.remote_controlconnection.app-server/README.mdto document onlystdio://,unix://,unix://PATH, andofffor local transports.ws://listen URLs.constant_time_eqdependency and refreshedCargo.lockaftercargo shearcaught the drift.Verification
ws://listen URL rejection.cargo shearcargo metadata --no-deps --format-version 1cargo test -p codex-app-server unix_socket_transportcargo test -p codex-app-server unix_socket_disconnectjust fix -p codex-app-servergit diff --checkLocal full Rust test execution was blocked before compilation by an external fetch failure for the pinned
nornagon/crosstermgit dependency.just bazel-lock-updateandjust bazel-lock-checkwere retried after the manifest cleanup but remain blocked by external BuildBuddy/V8 fetch timeouts.