Skip to content

[codex] Eliminate direct writes to GITHUB_ENV#21832

Draft
ww-oai wants to merge 1 commit intomainfrom
ww/gh-env
Draft

[codex] Eliminate direct writes to GITHUB_ENV#21832
ww-oai wants to merge 1 commit intomainfrom
ww/gh-env

Conversation

@ww-oai
Copy link
Copy Markdown
Contributor

@ww-oai ww-oai commented May 8, 2026

This eliminates some direct writes to ${GITHUB_ENV} in our custom (in-repo) actions. The idea behind this is twofold:

  1. Reduce the amount of global mutation we do, to make individual steps less stateful (or where stateful, clearly initialized);
  2. Eliminate a (minor) source of code injection risk, i.e. where a manipulated input induces us into setting environment variables that can be pivoted into code execution (things like LD_PRELOAD).

In practice (2) is not a real security risk at the moment, since the inputs to ${GITHUB_ENV} are not sufficiently attacker-controllable. But we should still address it for defense-in-depth.

@ww-oai ww-oai self-assigned this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant