[codex] cache remote plugin marketplaces during startup#21830
Draft
[codex] cache remote plugin marketplaces during startup#21830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
plugin/listcurrently fetches remote marketplace data on demand, so the first@lookup or Plugins page open can still pay remote catalog latency even though startup is already doing related remote-plugin work. There is also a startup race where a foreground request can overlap the warmup and trigger the same remote fetch again.What changed
plugin/listthrough the shared cache pathValidation
cargo test -p codex-core-pluginscargo test -p codex-app-server plugin_list_includes_remote_marketplaces_when_remote_plugin_enabled -- --nocapturejust fmtjust fix -p codex-core-pluginsjust fix -p codex-app-serverNotes
cargo test -p codex-app-serverstill has unrelated local-environment failures in existing sandboxed command-exec tests (sandbox-exec: sandbox_apply: Operation not permitted) plus unrelated timing-sensitive tests. The touched remote-plugin path passed its focused coverage.