Conversation
|
I have read the CLA Document and I hereby sign the CLA Nick Baumann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
baumann-oai
changed the title
| if let Some(metrics) = codex_otel::metrics::global() { | ||
| let _ = metrics.counter( | ||
| "codex.multi_agent.nickname_pool_reset", | ||
| "codex.multi_agent.nickname_candidates_reset", |
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn spawn_thread_subagent_prefers_role_candidates_over_global_nickname_candidates() { |
| Ok(Some(normalized_candidates)) | ||
| } | ||
|
|
||
| pub(crate) fn normalize_global_agent_nickname_candidates( |
There was a problem hiding this comment.
can you make sure we don't already have code doing the exact same thing?
Also, I don't think this should be pub(crate)
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn user_agents_nickname_candidates_are_used_without_project_override() -> std::io::Result<()> |
There was a problem hiding this comment.
Let's avoid adding useless tests. Most of them are very low value. Let's try to have one very good test instead
|
|
||
| /// Named global fallback nickname candidate packs keyed by pack name. | ||
| #[serde(default)] | ||
| pub nickname_packs: BTreeMap<String, Vec<String>>, |
There was a problem hiding this comment.
Do we really need this? This sounds going a bit too far IMO
Customisation is cool but up to a given limit IMO
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
3 participants
Summary
config.tomlto define a globalnickname_candidateslist for spawned agents, with role-specific candidates still taking precedence when present.Testing
just write-config-schemacargo test -p codex-core