Closed
Conversation
Collaborator
mzeng-openai
commented
Mar 18, 2026
mzeng-openai
commented
- Add i18n scaffolding, initially supporting elicitation messages.
ja-openai
reviewed
Mar 18, 2026
ja-openai
reviewed
Mar 18, 2026
ja-openai
approved these changes
Mar 19, 2026
ja-openai
left a comment
ja-openai
left a comment
There was a problem hiding this comment.
looks good! just one change for the en directory (and a tiny comment on locale fallback)
| @@ -0,0 +1,114 @@ | |||
| approval-header = Approve app tool call? | |||
There was a problem hiding this comment.
let's just call that directory: en , that's the default locale in Mojito
|
|
||
| Codex resolves locales to canonical locale codes, preferring specific locale | ||
| codes first, then generic language codes, and finally `en-US`. For example, | ||
| `zh-HK` falls back to `zh` when there is no `zh-HK` resource bundle. |
There was a problem hiding this comment.
nit: probably comes from the current files present in the scaffold, but might be a bit misleading for later. we'd want zh-hk to fallback to zh-hant in the list of Mojito locales not zh
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.