refactor: rename gpt-5-4-prompting skill to codex-prompting#307
Open
tonyyunyang wants to merge 1 commit intoopenai:mainfrom
Open
refactor: rename gpt-5-4-prompting skill to codex-prompting#307tonyyunyang wants to merge 1 commit intoopenai:mainfrom
tonyyunyang wants to merge 1 commit intoopenai:mainfrom
Conversation
The skill label baked in a specific GPT generation, so it goes stale whenever the underlying model iterates. Codex itself already routes to whatever model the user has configured in ~/.codex/config.toml, so the skill name shouldn't promise a specific generation. - Rename folder + SKILL.md frontmatter: gpt-5-4-prompting -> codex-prompting - Drop "GPT-5.4" mentions from skill body and reference files - Update cross-references in agents/codex-rescue.md and codex-cli-runtime - Replace gpt-5.4-mini examples in README with <your-model> placeholder - Update test assertions in commands.test.mjs to match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpt-5-4-promptingskill tocodex-promptingso the label doesn't go stale as GPT iterates. The skill is really about prompting Codex (the runtime), not a specific GPT generation, and Codex already routes to whatever model the user has configured.agents/codex-rescue.mdandskills/codex-cli-runtime/SKILL.md.gpt-5.4-ministrings in the README and the agent's model-passthrough rule with a<your-model>placeholder, since the actual model selection flows through~/.codex/config.tomland--model.tests/commands.test.mjsto match.Net-zero diff: 8 files, 21 insertions, 21 deletions. Folder rename detected by git (history preserved).
Test plan
node --test tests/commands.test.mjs— all 8 assertions pass on the new branchgpt-5-4/GPT-5.4/gpt-5.4-ministrings in user-facing.md/.mjs/.json/.toml(verified via grep)runtime.test.mjsandstate.test.mjsconfirmed unrelated — same 4 failures appear on baselinemainwhen this branch's changes are stashedNotes
tests/fake-codex-fixture.mjsstill hasgpt-5.4as a mock-server fallback. It's internal test infrastructure (not user-facing, not asserted on); left untouched to keep the diff minimal.