Skip to content

fix tibber remove of outdated prices #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 2 commits into from
Nov 26, 2025
Merged

fix tibber remove of outdated prices #2973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe812a7
fix tibber remove of outdated prices
LKuemmel Nov 26, 2025
da440fe
fix
LKuemmel Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions packages/control/optional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from math import ceil
import random
from threading import Thread
from typing import List, Optional as TypingOptional, Union
from typing import Dict, List, Optional as TypingOptional, Union
from datetime import datetime, timedelta

from control import data
Expand Down Expand Up @@ -150,20 +150,25 @@ def __get_first_entry(self) -> tuple[str, float]:
return timestamp, first

def remove_outdated_prices(self):
def remove(price_data: Dict) -> Dict:
price_timeslot_seconds = self.__calculate_price_timeslot_length(price_data)
now = timecheck.create_timestamp()
return {
price[0]: price[1]
for price in price_data.items()
if float(price[0]) > now - (price_timeslot_seconds - 1)
}

if self.data.electricity_pricing.configured:
prices = self.data.electricity_pricing.get.prices
if prices is None or len(prices) == 0:
log.debug("Keine Preisdaten für strompreisbasiertes Laden vorhanden.")
else:
price_timeslot_seconds = self.__calculate_price_timeslot_length(prices)
now = timecheck.create_timestamp()
prices = {
price[0]: price[1]
for price in prices.items()
if float(price[0]) > now - (price_timeslot_seconds - 1)
}
self.data.electricity_pricing.get.prices = prices
Pub().pub("openWB/set/optional/ep/get/prices", prices)
ep = self.data.electricity_pricing
ep.get.prices = remove(ep.get.prices)
Pub().pub("openWB/set/optional/ep/get/prices", ep.get.prices)
if self._flexible_tariff_module:
ep.flexible_tariff.get.prices = remove(ep.flexible_tariff.get.prices)
Pub().pub("openWB/set/optional/ep/flexible_tariff/get/prices", ep.flexible_tariff.get.prices)
if self._grid_fee_module:
ep.grid_fee.get.prices = remove(ep.grid_fee.get.prices)
Pub().pub("openWB/set/optional/ep/grid_fee/get/prices", ep.grid_fee.get.prices)

def __get_current_timeslot_start(self) -> int:
timestamp = self.__get_first_entry()[0]
Expand Down