refactor charging ev #2901
Merged
refactor charging ev #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKuemmel
force-pushed
the
refactor_charging_ev
branch
from
a1e3bc4 to
ea9193b
Compare
tpd-opitz
reviewed
Nov 4, 2025
| Pub().pub("openWB/set/chargepoint/"+str(self.num)+"/set/charging_ev", -1) | ||
| self.reset_control_parameter_at_charge_stop() | ||
| data.data.counter_all_data.get_evu_counter().reset_switch_on_off(self) | ||
| # Abstecken |
Contributor
There was a problem hiding this comment.
"strukturierende" Kommentare deuten auch verstecke Funktionen hin (Separation of Concerns)
packages/control/counter.py
Outdated
| if chargepoint.data.control_parameter.timestamp_switch_on_off is not None: | ||
| chargepoint.data.control_parameter.timestamp_switch_on_off = None | ||
| evu_counter = data.data.counter_all_data.get_evu_counter() | ||
| # Wenn bereits geladen wird, freigegebene Leistung freigeben. Wenn nicht geladen wird, reservierte |
Contributor
There was a problem hiding this comment.
was genau ist die "freigegebene Leistung", die hier freigegeben werden soll? Ist womöglich "nicht genutzte Leistung" gemeint?
LKuemmel
force-pushed
the
refactor_charging_ev
branch
from
ea9193b to
70d52d8
Compare
LKuemmel
force-pushed
the
refactor_charging_ev
branch
from
70d52d8 to
6d21154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.