Revert ValueError for NaN values SMA #2887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set power_total to 0 and currents to [0, 0, 0] when power_total is not valid.
LKuemmel
requested changes
Nov 3, 2025
Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
LKuemmel
added a commit
to LKuemmel/core
that referenced
this pull request
Nov 6, 2025
* Handle invalid power_total by resetting values Set power_total to 0 and currents to [0, 0, 0] when power_total is not valid. * Helptext improved Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com> --------- Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
LKuemmel
added a commit
that referenced
this pull request
Nov 10, 2025
* add frequency (#2792) * temp charge templates as option (#2855) * draft * draft * temp charge templates optional * fix temporary settings optional (#2868) * fix temporary charge template: change vehicle (#2869) * improve error handling internal cp (#2814) * fix single phase wallboxes (#2836) * SMA SunnyBoy - fix phase currents for single phase inverters (#2844) * support single phase inverters * handle power and currents NaN values * Revert ValueError for NaN values SMA (#2887) * Handle invalid power_total by resetting values Set power_total to 0 and currents to [0, 0, 0] when power_total is not valid. * Helptext improved Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com> --------- Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com> * improve register check (#2906) * build all themes (#2886) * build all themes * remove hard coded theme bases --------- Co-authored-by: Lutz Bender <github@lutz-bender.de> * fix build themes wotkflow (#2903) * temporary settings active: only update temporary settings for changed… (#2879) * temporary settings active: only update temporary settings for changed persistent templates * fix * update config * fix * fix * fix * clean up * Koala - Add Input dialog for editing scheduled and time plans (#2895) * Add scheduled details component * Add / remove scheduled charging plan - details as dialog * Add time plan details - adjust backend command * Backend command * Add DC charging inputs * Display bidi settings in scheduled plan based on vehicle profile bidi enabled * Fix DC power values for scheduled and time planes * Close plan dialog upon plan deletion * Plan energy amount watts to kilowatts * Formatting fixes * Charging current title AC or DC * Formatting fix * Change add plan button outlined to filled * Formatting Delete plan button * Add kW label to DC power input field * Format input fields * Format input toggles --------- Co-authored-by: BrettS <brett.scott@openwb.de> * fix temporary charge temple: inactive-> update all cps using this template (#2907) * Update version 2.1.8-Beta.Patch.4 * Fix: Skoda SoC fehlende Restreichweite (#2789) * fix: handle missing 'remainingRangeInKm' in status data * fix: update vehicle status API endpoint and adjust data extraction for battery status * flake8: format cruising range calculation for better readability * use API v2 endpoints with fallback to API v1 * fix: vehicle status handling to support hybrid cars * add tests * flake8: remove whitespace in blank line * remove id_token from flow (#2915) * Merge pull request #2910 from Brett-S-OWB:charge-plans-text-fix Charging plans text fixes - text as in settings / standard theme * buil UI --------- Co-authored-by: ndrsnhs <156670705+ndrsnhs@users.noreply.github.com> Co-authored-by: SeaSpotter <florian.horch@gmail.com> Co-authored-by: Lutz Bender <github@lutz-bender.de> Co-authored-by: BrettS <brett.scott@openwb.de> Co-authored-by: vuffiraa72 <u.mersewsky+github@gmail.com> Co-authored-by: benderl <benderl@users.noreply.github.com>
LKuemmel
added a commit
to LKuemmel/core
that referenced
this pull request
Nov 10, 2025
* Handle invalid power_total by resetting values Set power_total to 0 and currents to [0, 0, 0] when power_total is not valid. * Helptext improved Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com> --------- Co-authored-by: LKuemmel <76958050+LKuemmel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #2844
https://forum.openwb.de/viewtopic.php?p=135192#p135192
https://www.photovoltaikforum.com/thread/253547-hilfe-bei-sma-wechselrichter-modbus-register-30775/
SMA Wechselrichter (Tripower, Sunny Boy mindestens) geben Nachts immer NaN Werte aus, das führt doch jetzt zu vermehrt Support Anfragen weil Leute hier auf einen Fehler hingewiesen werden, der aber keiner ist. Die ursprüngliche Codezeile hat hier einfach power_total nachts auf 0 gesetzt und damit ist auch keine Fehlermeldung für unplausible Werte nötig.