Update secondary #2312
Merged
Update secondary #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKuemmel
requested changes
Apr 8, 2025
packages/helpermodules/command.py
Outdated
| hostname=SubData.cp_data[payload["data"]["chargepoint"] | ||
| ].chargepoint.chargepoint_module.config.configuration.ip_address) | ||
|
|
||
| def chargepointUpdate(self, payload: dict) -> None: |
Contributor
There was a problem hiding this comment.
Suggested change
| def chargepointUpdate(self, payload: dict) -> None: | |
| def secondaryChargepointUpdate(self, payload: dict) -> None: |
Diese Methode funktioniert nur mit Ladepunkten vom Typ series im Modus secondary.
| elif ("/get/version" in msg.topic or | ||
| "/get/current_branch" in msg.topic or | ||
| "/get/current_commit" in msg.topic): | ||
| self._validate_value(msg, str) |
Contributor
There was a problem hiding this comment.
Fehlt in der setdata nicht noch die neue Einstellung "secondary_auto_update"?
| "^openWB/chargepoint/[0-9]+/get/powers$", | ||
| "^openWB/chargepoint/[0-9]+/get/power_factors$", | ||
| "^openWB/chargepoint/[0-9]+/get/vehicle_id$", | ||
| "^openWB/chargepoint/[0-9]+/get/version$", |
Contributor
There was a problem hiding this comment.
Hier fehlt auch der Eintrag für secondary_auto_update.
LKuemmel
approved these changes
Apr 10, 2025
LKuemmel
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openWB/openwb-ui-settings#691