Skip to content

minor fixes #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benderl merged 3 commits into from
Mar 26, 2025
Merged

minor fixes #2278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5981d41
Dimm-Kit API fix
benderl Mar 25, 2025
d2b3fb4
fix IoState initialization
benderl Mar 25, 2025
c7f7f23
add user to group video
benderl Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/modules/common/store/_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
class IoValueStoreBroker(ValueStore[IoState]):
def __init__(self, num: int) -> None:
self.num = num
self.state = IoState()

def set(self, state: IoState) -> None:
self.state = state
Expand Down
5 changes: 3 additions & 2 deletions packages/modules/io_devices/dimm_kit/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@ def read():
pin.value, 1, unit=config.configuration.modbus_id
) for pin in DigitalOutputMapping})

def write(analog_output: Optional[Dict[str, int]], digital_output: Optional[Dict[str, int]]) -> None:
def write(analog_output: Optional[Dict[str, int]], digital_output: Optional[Dict[str, bool]]) -> None:
for i, value in digital_output.items():
client.write_single_coil(DigitalOutputMapping[i].value, value, unit=config.configuration.modbus_id)
client.write_single_coil(DigitalOutputMapping[i].value, 1 if value is True else 0,
unit=config.configuration.modbus_id)

version = False
client = ModbusTcpClient_(config.configuration.host, config.configuration.port)
Expand Down
2 changes: 1 addition & 1 deletion runs/atreboot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ chmod 666 "$LOGFILE"
# check group membership
echo "Group membership..."
# ToDo: remove sudo group membership if possible
for group in "input" "dialout" "gpio" "sudo"; do
for group in "input" "dialout" "gpio" "sudo" "video"; do
if ! groups openwb | grep --quiet "$group"; then
if getent group | cut -d: -f1 | grep --quiet "$group"; then
sudo usermod -G "$group" -a openwb
Expand Down