Use --connect-timeout 3 in setup_network.sh : check_internet_connection #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curls seems to have a very long default timeout causing the whole subdata to hang when in secondary mode. This is because setup_network.sh is called from line 630 of subdata.py - control path for "extern" openwb.
benderl
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #2226 by using
--connect-timeout 3option withcurl.This will result in detecting "no internet" after at most 3 seconds.
If Internet is available, it should really be possible to contact GitHub within 3 seconds. Else Internet seems so bad that it should probably be considered "inavailable".
Ideally, also the call to
runs/setup_network.shshould not be made at all from within the message processing code ofsubdata.py. At least not as long as the script can block multiple seconds or minutes.