update valid topics #2190
Merged
update valid topics #2190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKuemmel
force-pushed
the
fix
branch
2 times, most recently
from
4f38055 to
accdc68
Compare
benderl
requested changes
Mar 18, 2025
packages/control/optional.py
Outdated
|
|
||
| def et_price_lower_than_limit(self, max_price: float): | ||
| """ prüft, ob der aktuelle Strompreis unter der festgelegten Preisgrenze liegt. | ||
| def et_price_lower_or_equal_than_limit(self, max_price: float): |
Contributor
There was a problem hiding this comment.
Die richtige Bezeichnung wäre et_price_lower_than_or_equal_to_limit.
So ausführliche Namen haben aber auch den Nachteil, dass sie potentiell mal geändert werden müssen, wenn sich die Logik ändert. Genau das war wohl hier mal der Fall (kleiner -> kleiner/gleich). Also vielleicht eine etwas andere Bezeichnung wählen: et_charging_allowed.
rename method
rename method
benderl
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.