Skip to content

fix solaredge: don't remove component from hierarchy #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Jan 13, 2025
Merged

fix solaredge: don't remove component from hierarchy #2140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions packages/modules/devices/solaredge/solaredge/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,21 @@ def get_synergy_units(component_config: Union[SolaredgeBatSetup,
SolaredgeCounterSetup,
SolaredgeInverterSetup,
SolaredgeExternalInverterSetup]) -> None:
if client.read_holding_registers(40121, modbus.ModbusDataType.UINT_16,
unit=component_config.configuration.modbus_id
) == synergy_unit_identifier:
# Snyergy-Units vom Haupt-WR des angeschlossenen Meters ermitteln. Es kann mehrere Haupt-WR mit
# unterschiedlichen Modbus-IDs im Verbund geben.
log.debug("Synergy Units supported")
synergy_units = int(client.read_holding_registers(
40129, modbus.ModbusDataType.UINT_16,
unit=component_config.configuration.modbus_id)) or 1
log.debug(
f"Synergy Units detected for Modbus ID {component_config.configuration.modbus_id}: {synergy_units}")
else:
try:
if client.read_holding_registers(40121, modbus.ModbusDataType.UINT_16,
unit=component_config.configuration.modbus_id
) == synergy_unit_identifier:
# Snyergy-Units vom Haupt-WR des angeschlossenen Meters ermitteln. Es kann mehrere Haupt-WR mit
# unterschiedlichen Modbus-IDs im Verbund geben.
log.debug("Synergy Units supported")
synergy_units = int(client.read_holding_registers(
40129, modbus.ModbusDataType.UINT_16,
unit=component_config.configuration.modbus_id)) or 1
log.debug(
f"Synergy Units detected for Modbus ID {component_config.configuration.modbus_id}: {synergy_units}")
else:
synergy_units = 1
except Exception:
synergy_units = 1
return synergy_units
try:
Expand Down