Skip to content

Conversation

@MartinRinas
Copy link
Contributor

@MartinRinas MartinRinas commented Dec 16, 2024

Introduce functionality to redact sensitive information from log messages. This enhances security by preventing sensitive data from being logged.

validated with these SoC modules:

  • OVMS
  • SmartHello

validated with these meter modules:

  • Discovergy

@MartinRinas MartinRinas changed the title Implement sensitive log line redaction and token management Implement sensitive log line redaction (like tokens, passwords) Dec 16, 2024
@MartinRinas MartinRinas marked this pull request as ready for review December 17, 2024 21:15
@MartinRinas MartinRinas changed the title Implement sensitive log line redaction (like tokens, passwords) Redact credentials in logging Dec 18, 2024
Copy link
Contributor

@LKuemmel LKuemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe es mit dem Discovergy-Modul ausprobiert (Dummy-Daten). Der Logeintrag ist bei mir unverändert:

2025-01-02 13:03:00,543 - {control.data:279} - {INFO:MainThread} - device0
{'name': 'inexogy (Discovergy)', 'type': 'discovergy', 'vendor': 'discovergy', 'id': 0, 'configuration': {'user': 'srh', 'password': 'sdhf'}}

https://paste.openwb.de/H0OvaswurNZ2Q5e
Kannst du dir das bitte ansehen?

Copy link
Contributor Author

@MartinRinas MartinRinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem war dass die JSON Daten mit single quotes anstelle der von JSON geforderten double quotes protokolliert werden. Nun wird beides erkannt und adressiert.

@LKuemmel LKuemmel added this to the 2.1.7 milestone Jan 2, 2025
@LKuemmel LKuemmel merged commit c509166 into openWB:master Jan 2, 2025
1 check passed
@MartinRinas MartinRinas deleted the feature-RedactLogfiles branch January 2, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants