Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
jona159
approved these changes
Mar 18, 2026
Contributor
jona159
left a comment
There was a problem hiding this comment.
Should we come up with some criteria when we should use a component-level error boundary? It is still a bit unclear to me when we would want to favor it over the root error boundary
Member
Author
I have added a quick note above the function itself until there is a better place to put this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
First of all the arguably rashly copy-and-pasted duplications of the ever same error boundary were removed.
Some unused code was cleaned up and a generic boundary was added.
This way no component has to declare a boundary itself. They sure can, but don't have to.
Only "downside" to the generic boundary is, that it is displayed on a blank page. However there are convenient back buttons.
If a component wants to handle errors more gracefully, I think it should implement its own version of an error boundary that is more helpful than just showing the generic message but inside its own layout.
Checklist
devbranchAdditional Information