Skip to content

Conversation

@okurz
Copy link
Member

@okurz okurz commented Apr 4, 2025

Copy link
Member

@Wabri Wabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally for me, maybe the problem is with macos itself

@okurz okurz force-pushed the fix/sporadic_segfault branch 4 times, most recently from 9d3c09d to f514227 Compare April 4, 2025 14:04
@codecov
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (5a2fec3) to head (5fad8a3).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5a2fec3) and HEAD (5fad8a3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5a2fec3) HEAD (5fad8a3)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   97.89%   91.60%   -6.29%     
==========================================
  Files          27       45      +18     
  Lines         903     2848    +1945     
==========================================
+ Hits          884     2609    +1725     
- Misses         19      239     +220     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@okurz
Copy link
Member Author

okurz commented Apr 7, 2025

I don't think I can fix codecov/changes failing. The overall project coverage did not change and I assume after this PR merged everything will be fine as well. It is just that I changed rules and when to run with what details in CI. Please review and approve or let me know what to change

@okurz okurz force-pushed the fix/sporadic_segfault branch from f514227 to 7c2fa7f Compare April 7, 2025 11:54
@okurz
Copy link
Member Author

okurz commented Apr 7, 2025

I guess now CPAN is broken: https://github.com/openSUSE/Mojo-IOLoop-ReadWriteProcess/actions/runs/14308498488/job/40098020240?pr=79#step:5:831 says "Error: Can't locate Module/Build.pm in @inc"

@perlpunk
Copy link
Collaborator

perlpunk commented Apr 7, 2025

For some reason it doesn't install Module::Build, although it's in the cpanfile...

@perlpunk
Copy link
Collaborator

perlpunk commented Apr 7, 2025

There is something weird with https://github.com/shogo82148/actions-setup-perl I believe.

% cpanm --version
cpanm (App::cpanminus) version 1.9022 (/home/runner/work/_actions/shogo82148/actions-setup-perl/v1/bin/cpanm)

while the latest version on https://metacpan.org/dist/App-cpanminus is 1.7048

For my personal projects I usually use perl:$version images:
https://github.com/perlpunk/YAML-PP-p5/blob/master/.github/workflows/linux.yaml#L37

I was just told on IRC that it's https://metacpan.org/pod/Menlo::CLI::Compat behind the scenes: https://github.com/shogo82148/actions-setup-perl/blob/main/bin/cpanm#L11-L13

Still, it's somehow broken.

@perlpunk
Copy link
Collaborator

perlpunk commented Apr 7, 2025

In any case there is a workaround if we cannot get it working, just remove the step perl Build.pL; ./Build as we don't need that anyway.

Not needed to run tests and helps to avoid problems as observed in
openSUSE#79 (comment)
@okurz
Copy link
Member Author

okurz commented Apr 8, 2025

In any case there is a workaround if we cannot get it working, just remove the step perl Build.pL; ./Build as we don't need that anyway.

done that

@okurz okurz merged commit bc5514b into openSUSE:master Apr 8, 2025
18 of 34 checks passed
@okurz okurz deleted the fix/sporadic_segfault branch April 8, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants