-
Notifications
You must be signed in to change notification settings - Fork 15
t: Skip if pgrep is not installed #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Otherwise the test might fail, and sometimes we don't even see an error message with the reason, like observed in OBS or probably here on cpantesters: http://www.cpantesters.org/cpan/report/47446f5e-103b-11f0-98b0-b3c3213a625c http://www.cpantesters.org/cpan/report/57cba9ba-1017-11f0-98b0-b3c3213a625c
okurz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool. And now we have a CI failure which I have never seen before: https://github.com/openSUSE/Mojo-IOLoop-ReadWriteProcess/actions/runs/14251136067/job/39943920707?pr=78#step:6:88
|
We might want to use https://metacpan.org/pod/Proc::ProcessTable to replace pgrep |
|
If that supports process groups. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 97.78% 97.89% +0.11%
==========================================
Files 27 27
Lines 903 903
==========================================
+ Hits 883 884 +1
+ Misses 20 19 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For the record: |
I guess that would still mean needing to read multiple lines from that table to find out all processes in a group. Not really better. PR is ok as is |
Otherwise the test might fail, and sometimes we don't even see an error message with the reason, like observed in OBS or probably here on cpantesters:
http://www.cpantesters.org/cpan/report/47446f5e-103b-11f0-98b0-b3c3213a625c http://www.cpantesters.org/cpan/report/57cba9ba-1017-11f0-98b0-b3c3213a625c