-
Notifications
You must be signed in to change notification settings - Fork 15
Fix minil build + version 1.1.0 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
okurz
commented
Apr 2, 2025
- Prepare release of 1.1.0
- README: Update POD using minilla
- Try to prevent warnings about Formatter
- Update Build.PL and META.json with minilla 3.1.25
- Remove obsolete dependency on TAP::Formatter::Color
Wabri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If META.json is autogenerated taking the author commits than I think we should leave as it is, otherwise change to suse mail
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 89.70% 89.36% -0.34%
==========================================
Files 27 27
Lines 903 903
Branches 207 207
==========================================
- Hits 810 807 -3
Misses 21 21
- Partials 72 75 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It is auto-generated so I would leave it as-is unless we can fix what it does |
|
Who can help me understand "codecov/changes |
|
It is related to this https://app.codecov.io/gh/openSUSE/Mojo-IOLoop-ReadWriteProcess/pull/76/indirect-changes But I am wondering what does it means. I'm looking into https://docs.codecov.com/docs/unexpected-coverage-changes#how-to-find-the-root-cause |
|
I don't know what code changes codecov is referring to but we need this change merged so that we can do a proper release. Merging. |
|
See #77 about the coverage |