-
Notifications
You must be signed in to change notification settings - Fork 20
Intoduce usage agreement (issue #505) #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v6
Are you sure you want to change the base?
Intoduce usage agreement (issue #505) #567
Conversation
| "shortName" | ||
| ], | ||
| "properties": { | ||
| "contactInformation": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apdavison would you agree that this should be rather renamed to "mainContact" and offer a single string (format: email?) entry? (ContactInformation is currently handled privately only but that info should be public similar to supportChannel)
Co-authored-by: Lyuba Zehl <lyuba.zehl@ebrains.eu>
| "_linkedTypes": [ | ||
| "core:Copyright", | ||
| "core:License", | ||
| "core:UsageAgreement" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright should ideally not be linked but embedded, maybe there should be another schema defined that is linked here (and links to license/usage agreement but embeds copyright) or copyright has to remain a separate property
The big issue (with both) is that the properties have to become optional because a copyright could be the only necessary one, but may not be the important one for other cases.
@apdavison, @olinux and @lzehl: Any suggestions? We should probably discuss this in one of the developer meetings.
Address issue #505
Correct the errors of #559
legalPerson category will need to be updated in a future PR.
the controlledTerms ModificationRights will need to be added first (openMetadataInitiative/openMINDS_controlledTerms#512).