-
Notifications
You must be signed in to change notification settings - Fork 20
Draft for #513: Update of Actors, ResearchProducts,ResearchProductVersions, DigitalIdentifiers and their relationships. #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v6
Are you sure you want to change the base?
Conversation
…s,ResearchProductVersions, DigitalIdentifiers and their relationships.
…ts,ResearchProductVersions, DigitalIdentifiers and their relationships.
|
Not sure if it is relevant, but we could consider adding the property "_formats": ["iri"] for most of the digital identifiers. |
|
@Raphael-Gazzotti I'm a bit confused. This is an open discussion still. Let's wait a bit before continuing with this. |
| "email" | ||
| ], | ||
| "properties": { | ||
| "address": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, but I think we should call this location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussion with @apdavison we decided that for now we will not include address into the ContactInformation schema. however we would like to make email an array (of strings; format email).
| "required": [ | ||
| "contributor", | ||
| "type" | ||
| "role" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are in the Contribution schema I think this should remain type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed by @apdavison
| "uniqueItems": true, | ||
| "_instruction": "Add the party that performed the contribution.", | ||
| }, | ||
| "role": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should remain type considering that we are in the Contribution schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change to type
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "_type": "core:Affiliation", | |||
| "_type": "core:Membership", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to remain now Affiliation with the following properties
person -> Person (1)
organization -> Organization (1-N)
| "core:Contribution" | ||
| ] | ||
| }, | ||
| "custodian": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be removed
| "core:Contribution" | ||
| ] | ||
| }, | ||
| "custodian": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
lzehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add also the category "organizationIdentifier" to the RORID
| "email" | ||
| ], | ||
| "properties": { | ||
| "address": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussion with @apdavison we decided that for now we will not include address into the ContactInformation schema. however we would like to make email an array (of strings; format email).
| "required": [ | ||
| "contributor", | ||
| "type" | ||
| "role" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed by @apdavison
| "uniqueItems": true, | ||
| "_instruction": "Add the party that performed the contribution.", | ||
| }, | ||
| "role": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change to type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to following properties:
- name (string) (1) instructions: preferred name by organization (in international context)
- acronym (string) (0-1) instructions: preferred acronym by organization (in international context)
- alternateName (array of string) (0-1)
- jurisdiction: linked category "jurisdiction"
- location: linked type Location
- digitalIdentifier: array of linked category "organizationIdentifier"
- hasParent: linked type Organization
- homepage: string (IRI) (1)
- type: linked type OrganizationType
| "legalPerson" | ||
| ], | ||
| "required": [ | ||
| "fullName", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to preferredName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove givenName from required
| "type": "string", | ||
| "_instruction": "Enter the given name of this person." | ||
| }, | ||
| "memberOf": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove memberOf (directionality is reversed here)
| }, | ||
| "familyName": { | ||
| "type": "string", | ||
| "_instruction": "Enter the family name of this person." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instructions: Enter the family name, surname, or equivalent of this person.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove because it was provided in #566
Removed 'fullName' field and updated 'shortName' to 'name' with new instructions.
lzehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apdavison I would like your review on this as well. I corrected a couple of things in @Raphael-Gazzotti last update:
- keep "legalPerson" for Funding (because money can be only handed out by individuals or legal entities)
- optimized some instructions
- refer to OrganizationType instead of LegalEntityType (so that we are more flexible what to register in this instance library)
One thing to discuss left for this PR: should we rename ResearchProduct to Product and ResearchProductVersion to ProductVersion ?
| "sands:BrainAtlas", | ||
| "sands:BrainAtlasVersion", | ||
| "sands:CommonCoordinateSpace", | ||
| "sands:CommonCoordinateSpaceVersion" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update according to SAND update, i.e.:
BrainAtlas(Version) --> AnatomicalAtlasVersion
CommonCoordinateSpace(Version) --> CommonCoordinateFramework(Version)
|
this PR will also solve #493 (I think) |
No description provided.