Skip to content

Conversation

@Raphael-Gazzotti
Copy link
Member

No description provided.

…s,ResearchProductVersions, DigitalIdentifiers and their relationships.
…ts,ResearchProductVersions, DigitalIdentifiers and their relationships.
@Raphael-Gazzotti Raphael-Gazzotti self-assigned this Aug 14, 2025
@Raphael-Gazzotti Raphael-Gazzotti added request any request or update for schemas major update large workload or major update needed to complete labels Aug 14, 2025
@Raphael-Gazzotti Raphael-Gazzotti marked this pull request as draft August 14, 2025 11:11
@Raphael-Gazzotti
Copy link
Member Author

Not sure if it is relevant, but we could consider adding the property "_formats": ["iri"] for most of the digital identifiers.

@lzehl
Copy link
Member

lzehl commented Oct 11, 2025

@Raphael-Gazzotti I'm a bit confused. This is an open discussion still. Let's wait a bit before continuing with this.

"email"
],
"properties": {
"address": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but I think we should call this location

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussion with @apdavison we decided that for now we will not include address into the ContactInformation schema. however we would like to make email an array (of strings; format email).

"required": [
"contributor",
"type"
"role"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are in the Contribution schema I think this should remain type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed by @apdavison

"uniqueItems": true,
"_instruction": "Add the party that performed the contribution.",
},
"role": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should remain type considering that we are in the Contribution schema

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to type

@@ -1,5 +1,5 @@
{
"_type": "core:Affiliation",
"_type": "core:Membership",
Copy link
Member

@lzehl lzehl Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to remain now Affiliation with the following properties
person -> Person (1)
organization -> Organization (1-N)

"core:Contribution"
]
},
"custodian": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be removed

"core:Contribution"
]
},
"custodian": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add also the category "organizationIdentifier" to the RORID

"email"
],
"properties": {
"address": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussion with @apdavison we decided that for now we will not include address into the ContactInformation schema. however we would like to make email an array (of strings; format email).

"required": [
"contributor",
"type"
"role"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed by @apdavison

"uniqueItems": true,
"_instruction": "Add the party that performed the contribution.",
},
"role": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to following properties:

  • name (string) (1) instructions: preferred name by organization (in international context)
  • acronym (string) (0-1) instructions: preferred acronym by organization (in international context)
  • alternateName (array of string) (0-1)
  • jurisdiction: linked category "jurisdiction"
  • location: linked type Location
  • digitalIdentifier: array of linked category "organizationIdentifier"
  • hasParent: linked type Organization
  • homepage: string (IRI) (1)
  • type: linked type OrganizationType

"legalPerson"
],
"required": [
"fullName",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to preferredName

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove givenName from required

"type": "string",
"_instruction": "Enter the given name of this person."
},
"memberOf": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove memberOf (directionality is reversed here)

},
"familyName": {
"type": "string",
"_instruction": "Enter the family name of this person."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instructions: Enter the family name, surname, or equivalent of this person.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove because it was provided in #566

@Raphael-Gazzotti Raphael-Gazzotti marked this pull request as ready for review November 14, 2025 09:07
Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apdavison I would like your review on this as well. I corrected a couple of things in @Raphael-Gazzotti last update:

  • keep "legalPerson" for Funding (because money can be only handed out by individuals or legal entities)
  • optimized some instructions
  • refer to OrganizationType instead of LegalEntityType (so that we are more flexible what to register in this instance library)

One thing to discuss left for this PR: should we rename ResearchProduct to Product and ResearchProductVersion to ProductVersion ?

Comment on lines +63 to +66
"sands:BrainAtlas",
"sands:BrainAtlasVersion",
"sands:CommonCoordinateSpace",
"sands:CommonCoordinateSpaceVersion"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update according to SAND update, i.e.:

BrainAtlas(Version) --> AnatomicalAtlasVersion
CommonCoordinateSpace(Version) --> CommonCoordinateFramework(Version)

openMetadataInitiative/openMINDS_SANDS#304

@lzehl
Copy link
Member

lzehl commented Dec 15, 2025

this PR will also solve #493 (I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major update large workload or major update needed to complete request any request or update for schemas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants