Skip to content

Fix string conversion for empty metadata instance objects #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehennestad merged 1 commit into from
Oct 24, 2025
Merged

Fix string conversion for empty metadata instance objects #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions code/internal/+openminds/+abstract/ControlledTerm.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
propValues.id (1,1) string
end

if isstring(instanceSpec) && isscalar(instanceSpec) && instanceSpec == ""
instanceSpec = string.empty;
end

if ~isempty(instanceSpec)
if ischar(instanceSpec)
instanceSpec = string(instanceSpec);
Expand Down
8 changes: 5 additions & 3 deletions code/internal/+openminds/+internal/+mixin/CustomInstanceDisplay.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@
end

function str = string(obj)
if numel(obj) > 1
str = strjoin( arrayfun(@(x) string(x.DisplayString), obj ), '; ');
else
if isempty(obj)
str = string.empty;
elseif isscalar(obj)
str = string( obj.DisplayString );
else
str = strjoin( arrayfun(@(x) string(x.DisplayString), obj ), '; ');
end
end

Expand Down