WEB-924 View loan originator and edit loan originator page titles displaying raw translation key instead of localized text#3510
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
i18n translation files src/assets/translations/cs-CS.json, de-DE.json, en-US.json, es-CL.json, es-MX.json, fr-FR.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, sw-SW.json |
Added two new translation keys: "View Loan Originator" and "Edit Loan Originator" with language-specific translations. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
- WEB-689: Fix Spanish Translation #3121: Modifies the same translation files (es-CL, es-MX) and updates loan-originator/loan-related terminology, providing context for loan-related translation patterns.
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: adding missing translation keys for 'View Loan Originator' and 'Edit Loan Originator' to fix pages displaying raw translation keys instead of localized text. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Warning
Review ran into problems
🔥 Problems
Timed out fetching pipeline failures after 30000ms
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/assets/translations/pt-PT.json`:
- Around line 3331-3332: The two new translation entries "View Loan Originator"
and "Edit Loan Originator" use "Agente de Crédito" which is inconsistent with
the rest of the locale that uses "Originador de Empréstimo(s)"; update the
values for the keys "View Loan Originator" and "Edit Loan Originator" to use the
consistent term (e.g., "Ver Originador de Empréstimo" and "Editar Originador de
Empréstimo") so all related keys in the file use the same Portuguese wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8c5e10fa-c129-478c-bb17-f4d8df2c821a
📒 Files selected for processing (13)
src/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
…playing raw translation key instead of localized text
674a40a to
819ebd8
Compare
Changes Made :-
-Added missing "View Loan Originator" and "Edit Loan Originator" translation keys to the labels.text section of all 13 language files .
WEB-924
Before :-

After :-

Summary by CodeRabbit