Fix build failures across all KMP targets (JVM, JS, WASM, iOS) by Arinyadav1 · Pull Request #2608 · openMF/android-client

Arinyadav1 · 2026-02-12T19:31:08Z

Fixes - Jira-#644

coderabbitai · 2026-02-12T19:31:21Z

Important

Review skipped

Too many files!

This PR contains 226 files, which is 76 over the limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

biplab1 · 2026-02-13T14:47:28Z

build-logic/convention/src/main/kotlin/KMPRoomConventionPlugin.kt

                    "kspDesktop",
                    "kspAndroid",
                    "kspIosArm64",
-                    "kspIosX64",


Can you tell us the reason for removal of this line? I can see it is present in kmp project template.

Currently we are using latest Paging library which is support KMP so that library align with JetBrains and JetBrains deprecated kspIosX64 it that's why I remove it.

biplab1 · 2026-02-13T14:51:26Z

build-logic/convention/build.gradle.kts

-    kotlinOptions {
-        jvmTarget = JavaVersion.VERSION_17.toString()
+    compilerOptions {
+        jvmTarget.set(JvmTarget.JVM_17)


Suggested change

jvmTarget.set(JvmTarget.JVM_17)

jvmTarget = JvmTarget.JVM_17

Cleaner and more idiomatic in Kotlin DSL.

biplab1 · 2026-02-13T14:56:02Z

cmp-android/src/main/kotlin/cmp/android/app/ComponentActivityExtensions.kt

-fun ComponentActivity.setupEdgeToEdge(
-    appThemeFlow: Flow<DarkThemeConfig>,
-) {
+@Suppress("MaxLineLength", "ktlint:standard:multiline-expression-wrapping")


This annotation isn't present in kmp-project-template: "ktlint:standard:multiline-expression-wrapping".

I will fix this one

biplab1 · 2026-02-13T14:57:50Z

cmp-android/src/main/kotlin/cmp/android/app/ComponentActivityExtensions.kt

- * will emit changes as needed.
+ * Emits whether the system is currently in dark mode.
 */
+@Suppress("ktlint:standard:multiline-expression-wrapping")


Same here, please review.

I will fix this one

biplab1 · 2026-02-13T15:05:17Z

cmp-android/build.gradle.kts

                file(System.getenv("KEYSTORE_PATH") ?: "../keystores/release_keystore.keystore")
            storePassword = System.getenv("KEYSTORE_PASSWORD") ?: "mifos1234"
-            keyAlias = System.getenv("KEYSTORE_ALIAS") ?: "mifos-mobile"
+            keyAlias = System.getenv("KEYSTORE_ALIAS") ?: "mifos"


Are you sure about this default value?

Yes, I am sure it is working fine

biplab1 · 2026-02-13T15:07:53Z

cmp-shared/build.gradle.kts


 kotlin {
    listOf(
-        iosX64(),


A question previously asked about its exclusion.

I have explained the reason in previously asked question

biplab1 · 2026-02-13T15:16:12Z

gradle.properties

 targetSdk=36
 compileSdk=36

-android.experimental.lint.version=8.8.2


This was added to fix Android build and publish workflow:

Added lint config in gradle properties to fix version incompatibility between lint and AGP.

Are you sure about this change that it won't break the workflow?

Yes' it is working fine

biplab1 · 2026-02-13T15:25:46Z

...re/savings/savingsAccountTransactionReceipt/SavingsAccountTransactionReceiptScreen.wasmJs.kt

Can you tell us the reason for getting rid of the WasmJsNetworkMonitor.kt?

There was not have a correct implementation of it because in other target devices have other name file and other in wasmJs in other file that's why I just fix this file issue and make consistent with other target devices

biplab1 · 2026-02-13T15:26:08Z

...eature/savings/savingsAccountTransactionReceipt/SavingsAccountTransactionReceiptScreen.js.kt

Same here, please review.

There was not have a correct implementation of it because in other target devices have other name file and other in Js in other file that's why I just fix this file issue and make consistent with other target devices

biplab1 · 2026-02-13T15:27:40Z

feature/report/src/wasmJsMain/kotlin/com/mifos/feature/report/reportDetail/FileHelper.wasmJs.kt

Can you tell us the reason for repurposing the existing files instead of creating new ones?

I did not repurposing the existing files, I only created new files I don't know why this showing file here like this because in report module did not have wasmJs and Js target before this PR I added this as a new one

You can confirm this scenario in this image

core/network/src/wasmJsMain/kotlin/com/mifos/core/network/utils/ImageLoaderUtils.js.kt

And I deleted this file because there was not have expect function in commonMain so that's why it is nothing any use so simple I deleted it.

biplab1 · 2026-02-13T15:32:47Z

feature/report/src/jsMain/kotlin/com/mifos/feature/report/reportDetail/FileHelper.js.kt

Same here, please review.

I did not repurposing the existing files, I only created new files I don't know why this showing file here like this because in report module did not have wasmJs and Js target before this PR I added this as a new one

You can confirm this scenario in this image

core/network/src/jsMain/kotlin/com/mifos/core/network/utils/ImageLoaderUtils.js.kt

And I deleted this file because there was not have expect function in commonMain so that's why it is nothing any use so simple I deleted it.

biplab1 · 2026-02-13T15:33:28Z

...-tracking/src/wasmJsMain/kotlin/com/mifos/feature/path/tracking/PathTrackingScreen.wasmJs.kt

+@androidx.compose.runtime.Composable
+actual fun PathTrackingScreen(
+    onBackPressed: () -> Unit,
+    viewModel: com.mifos.feature.path.tracking.PathTrackingViewModel,


Please move this to import section.

biplab1 · 2026-02-13T15:33:49Z

...ure/path-tracking/src/jsMain/kotlin/com/mifos/feature/path/tracking/PathTrackingScreen.js.kt

+@androidx.compose.runtime.Composable
+actual fun PathTrackingScreen(
+    onBackPressed: () -> Unit,
+    viewModel: com.mifos.feature.path.tracking.PathTrackingViewModel,


Same here, please review.

biplab1 · 2026-02-13T15:34:28Z

...e/groups/src/wasmJsMain/kotlin/com/mifos/feature/groups/groupList/GroupsListScreen.wasmJs.kt

+    paddingValues: androidx.compose.foundation.layout.PaddingValues,
+    onAddGroupClick: () -> Unit,
+    onGroupClick: (groupId: Int) -> Unit,
+    viewModel: com.mifos.feature.groups.groupList.GroupsListViewModel,


Please move relevant lines to import section.

biplab1 · 2026-02-13T15:34:44Z

feature/groups/src/jsMain/kotlin/com/mifos/feature/groups/groupList/GroupsListScreen.js.kt

+    paddingValues: androidx.compose.foundation.layout.PaddingValues,
+    onAddGroupClick: () -> Unit,
+    onGroupClick: (groupId: Int) -> Unit,
+    viewModel: com.mifos.feature.groups.groupList.GroupsListViewModel,


Same here, please review.

biplab1 · 2026-02-13T15:36:54Z

...ure/client/src/wasmJsMain/kotlin/com/mifos/feature/client/charges/ShowClientCharge.wasmJs.kt

+    pagingFlow: kotlinx.coroutines.flow.Flow<androidx.paging.PagingData<com.mifos.core.model.objects.clients.Page<com.mifos.room.entities.client.ChargesEntity>>>,
+    onAction: (com.mifos.feature.client.charges.ChargesAction) -> Unit,


Same here, please review.

biplab1 · 2026-02-13T15:40:03Z

feature/client/src/jsMain/kotlin/com/mifos/feature/client/charges/ShowClientCharge.js.kt

+actual fun ShowClientCharge(
+    pagingFlow: kotlinx.coroutines.flow.Flow<androidx.paging.PagingData<com.mifos.core.model.objects.clients.Page<com.mifos.room.entities.client.ChargesEntity>>>,
+    onAction: (com.mifos.feature.client.charges.ChargesAction) -> Unit,


Same here, please review.

biplab1 · 2026-02-13T16:22:44Z

...nter/src/wasmJsMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.wasmJs.kt

+    state: com.mifos.feature.center.centerList.ui.CenterListUiState,
+    isInSelectionMode: Boolean,
+    selectedItems: com.mifos.feature.center.centerList.ui.SelectedItemsState,
+    onRefresh: () -> Unit,


Please move relevant lines to import section.

biplab1 · 2026-02-13T16:22:57Z

feature/center/src/jsMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.js.kt

+    state: com.mifos.feature.center.centerList.ui.CenterListUiState,
+    isInSelectionMode: Boolean,
+    selectedItems: com.mifos.feature.center.centerList.ui.SelectedItemsState,


Same here, please review.

sonarqubecloud · 2026-02-14T07:56:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Arinyadav1 added 3 commits February 12, 2026 21:35

Fix Multiplatform build configuration

ee5318f

add comments and fix some issues

6c41e60

fix typeMap navigation for JVM target

037d01d

Merge branch 'development' into Fix-build-failures

2ee4642

biplab1 reviewed Feb 13, 2026

View reviewed changes

fix lint and import issue

439e86c

		pagingFlow: kotlinx.coroutines.flow.Flow<androidx.paging.PagingData<com.mifos.core.model.objects.clients.Page<com.mifos.room.entities.client.ChargesEntity>>>,
		onAction: (com.mifos.feature.client.charges.ChargesAction) -> Unit,

Conversation

Arinyadav1 commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

biplab1 Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 14, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

coderabbitai bot commented Feb 12, 2026 •

edited

Loading

biplab1 Feb 13, 2026 •

edited

Loading