Feat(client) show loan status under type#2605
Feat(client) show loan status under type#2605piyushs-05 wants to merge 4 commits intoopenMF:developmentfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| Box( | ||
| modifier = Modifier | ||
| .align(Alignment.TopEnd) | ||
| .padding(top = 8.dp, end = 8.dp) // Adjust padding to sit nicely on the icon corner |
There was a problem hiding this comment.
I think it is better to remove comments like those
| (loan.amountPaid ?: "Not Available").toString() | ||
| ), | ||
| type = loan.loanType?.value ?: "Not Available", | ||
| status = loan.status?.value ?: "Not Available", |
There was a problem hiding this comment.
it would be better if this is not hardcoded, I think
| Box( | ||
| modifier = Modifier | ||
| .align(Alignment.TopEnd) | ||
| .padding(top = 8.dp, end = 8.dp) // Adjust padding to sit nicely on the icon corner |
There was a problem hiding this comment.
Use DesignToken.padding instead of hardcoded 8.dp. The 8.dp dot size might be too small - test on various devices. Also, add contentDescription for accessibility
|
|
||
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Composable | ||
| private fun FilterBottomSheet( |
There was a problem hiding this comment.
Can consider extracting this to a separate composable file if it grows
| selectedStatuses: Set<LoanStatusFilter>, | ||
| clearFilters: () -> Unit, | ||
| ) { | ||
| ModalBottomSheet( |
There was a problem hiding this comment.
The sheetState will reset on configuration changes or on rotation. Consider using rememberSaveable for the sheetState and verify the ViewModel properly persists selectedStatus across rotations.
|
3 participants
Fixes - Jira-#661
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.