Skip to content

feat(loan): implement loan repayment form parity with Web App (MIFOSA… #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gurnoorpannu wants to merge 23 commits into
base: development
Choose a base branch
from
+404 −231
Open

feat(loan): implement loan repayment form parity with Web App (MIFOSA… #2597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a8c29cb
feat(loan): implement loan repayment form parity with Web App (MIFOSA…
gurnoorpannu Feb 2, 2026
c430781
Merge branch 'development' into feature/loan-repayment-form-parity-clean
gurnoorpannu Feb 2, 2026
094be7e
implemented requested changes
gurnoorpannu Feb 2, 2026
6be78cf
Merge remote-tracking branch 'origin/feature/loan-repayment-form-pari…
gurnoorpannu Feb 2, 2026
1a504bc
Merge branch 'development' into feature/loan-repayment-form-parity-clean
gurnoorpannu Feb 3, 2026
242c5dd
made requested changes
gurnoorpannu Feb 4, 2026
35e73c8
Merge remote-tracking branch 'origin/feature/loan-repayment-form-pari…
gurnoorpannu Feb 4, 2026
838a8a3
Made changes requested
gurnoorpannu Feb 4, 2026
34d3d40
Fixing changes requested
gurnoorpannu Feb 6, 2026
736575c
feat(loan): implement loan repayment form parity with Web App (MIFOSA…
gurnoorpannu Feb 2, 2026
3ccf92d
implemented requested changes
gurnoorpannu Feb 2, 2026
276cccb
made requested changes
gurnoorpannu Feb 4, 2026
9cfa094
Made changes requested
gurnoorpannu Feb 4, 2026
0b356ad
Fixing changes requested
gurnoorpannu Feb 6, 2026
12a57fa
Fixing conflitcts
gurnoorpannu Feb 7, 2026
5dca051
Merge remote-tracking branch 'origin/feature/loan-repayment-form-pari…
gurnoorpannu Feb 7, 2026
da0da1e
implemented requested changes
gurnoorpannu Feb 7, 2026
35a47c4
Merge branch 'development' into feature/loan-repayment-form-parity-clean
gurnoorpannu Feb 10, 2026
bfa45cb
Merge branch 'development' into feature/loan-repayment-form-parity-clean
gurnoorpannu Feb 11, 2026
fe61b9f
implemented coderabbit suggestions
gurnoorpannu Feb 12, 2026
518dcb7
Merge remote-tracking branch 'origin/feature/loan-repayment-form-pari…
gurnoorpannu Feb 12, 2026
0ebdc13
Added the externalId field
gurnoorpannu Feb 13, 2026
3782f02
Merge branch 'development' into feature/loan-repayment-form-parity-clean
gurnoorpannu Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...rc/commonMain/kotlin/com/mifos/room/entities/accounts/loans/LoanRepaymentRequestEntity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ data class LoanRepaymentRequestEntity(

val accountNumber: String? = null,

val externalId: String? = null,

val checkNumber: String? = null,

val routingCode: String? = null,
Expand Down
15 changes: 15 additions & 0 deletions feature/loan/src/commonMain/composeResources/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,5 +293,20 @@
<!-- Handle Error-->
<string name="field_empty">This field cannot be empty</string>

<!-- Loan Repayment Form Enhancements (MIFOSAC-643) -->
<string name="feature_loan_transaction_breakdown">Transaction Breakdown</string>
<string name="feature_loan_interest">Interest</string>
<string name="feature_loan_fees">Fees</string>
<string name="feature_loan_penalties">Penalties</string>
<string name="feature_loan_show_payment_details">Show Payment Details</string>
<string name="feature_loan_external_id_field">External ID</string>
<string name="feature_loan_cheque_number">Cheque Number</string>
<string name="feature_loan_routing_code">Routing Code</string>
<string name="feature_loan_receipt_number">Receipt Number</string>
<string name="feature_loan_bank_number">Bank Number</string>
<string name="feature_loan_note">Note</string>
<string name="feature_loan_waive_penalties">Waive Penalties</string>
<string name="feature_loan_no_penalties_found">No penalties found</string>
<string name="feature_loan_payment_success_message">Payment submitted successfully. Transaction ID: </string>
Copy link

@coderabbitai coderabbitai bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use a format placeholder instead of string concatenation for the transaction ID.

This string ends with ": " and expects the caller to concatenate the transaction ID at runtime. This breaks localization — translators can't reorder the sentence. Line 148 already uses the correct pattern with %1$s.

Proposed fix 
-    <string name="feature_loan_payment_success_message">Payment submitted successfully. Transaction ID: </string>
+    <string name="feature_loan_payment_success_message">Payment submitted successfully. Transaction ID: %1$s</string>

Note: The calling code will also need to change from string concatenation to String.format() or the Compose equivalent (e.g., stringResource(R.string.feature_loan_payment_success_message, transactionId)).

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<string name="feature_loan_payment_success_message">Payment submitted successfully. Transaction ID: </string>
<string name="feature_loan_payment_success_message">Payment submitted successfully. Transaction ID: %1$s</string>
🤖 Prompt for AI Agents 
In `@feature/loan/src/commonMain/composeResources/values/strings.xml` at line 310,
The string resource feature_loan_payment_success_message currently ends with a
dangling colon and expects the caller to concatenate the transaction ID, which
breaks localization; change the resource to include a format placeholder (e.g.,
use %1$s) so translators can reorder the text, and update callers that currently
concatenate to use String.format / stringResource with the transactionId
argument; specifically modify the string named
feature_loan_payment_success_message and update any call sites that append the
transaction ID to use the formatted-resource API.


</resources>
Loading