feat: define writeByGrpc interface#163
Open
castlighting wants to merge 2 commits intoopenGemini:mainfrom
Open
Conversation
Signed-off-by: castlighting <castlighting233@gmail.com>
Signed-off-by: castlighting <castlighting233@gmail.com>
hezhangjian
approved these changes
Mar 1, 2025
weiping-code
reviewed
Mar 1, 2025
Member
weiping-code
left a comment
weiping-code
left a comment
There was a problem hiding this comment.
@xuthus5 check the definition of writeByGrpc method.
| * @param database the name of the database. | ||
| * @param points the points to write. | ||
| */ | ||
| CompletableFuture<Void> writeByGrpc(String database, List<Point> points); |
Member
There was a problem hiding this comment.
The parameter is modified to(WriteRequest writeRequest),referring to the definition in the Go SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.