Fixed camera stream too big and colorimetry setting #137
+1,611
−903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsjudka
reviewed
Mar 14, 2023
| { | ||
| this->screen = QGuiApplication::primaryScreen(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
you'll want to remove your personal changes here
rsjudka
reviewed
Mar 14, 2023
| DASH_LOG(info) << "[CameraPage] Creating GStreamer pipeline with " << this->config->get_cam_local_device().toStdString(); | ||
| std::string pipeline = "v4l2src device=" + this->config->get_cam_local_device().toStdString() + | ||
| " ! capsfilter caps=\"video/x-raw,width=" + std::to_string(res.width()) + ",height=" + std::to_string(res.height()) + ";image/jpeg,width=" + std::to_string(res.width()) + ",height=" + std::to_string(res.height()) + "\"" + | ||
| " ! capsfilter caps=\"video/x-raw,width=" + std::to_string(res.width()) + ",height=" + std::to_string(res.height()) + ",colorimetry=bt601;image/jpeg,width=" + std::to_string(res.width()) + ",height=" + std::to_string(res.height()) + "\"" + |
Contributor
There was a problem hiding this comment.
does that break the pipeline for other cameras? we'll want to add something similar to this->config->get_cam_local_device() (and maybe default it to an empty string?) if that's the case
Author
There was a problem hiding this comment.
Idk if it breaks or if it works. For my camera it works. Someone gotta test this out. But I think it would be perfect to put it in the config like you said.
test rimosso bloccato
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Checklist: