Add address and hostname about connected client via OPC UA#25
Open
denise-opendaq wants to merge 2 commits into
Open
Add address and hostname about connected client via OPC UA#25denise-opendaq wants to merge 2 commits into
denise-opendaq wants to merge 2 commits into
Conversation
viacheslauK
reviewed
May 21, 2026
| char hostBuf[NI_MAXHOST] = {}; | ||
| getnameinfo(reinterpret_cast<struct sockaddr*>(&addr), addrLen, | ||
| ipBuf, sizeof(ipBuf), nullptr, 0, NI_NUMERICHOST); | ||
| getnameinfo(reinterpret_cast<struct sockaddr*>(&addr), addrLen, |
Contributor
There was a problem hiding this comment.
getnameinfo without NI_NUMERICHOST does a blocking reverse DNS lookup. This runs on the OPC UA server's single processing thread, so while DNS is resolving, the server cannot process anything else (no responses to other clients, no new connections). In environments where the connecting IP has no PTR record or DNS is slow, this can stall the server for up to seconds. Additionally, if there is a buggy client in the network that constantly connects to and disconnects from the server, it may cause problems for other clients as well.
@JakaMohorko What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server brings the socket from the open62451 library and reads address and hostname of the connected client to use it in creating ConnectedClientInfo