Skip to content

Override getSignalNoLock #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakaMohorko merged 1 commit into from
Mar 17, 2026
Merged

Override getSignalNoLock #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ies/opcuatms/opcuatms_client/include/opcuatms_client/objects/tms_client_input_port_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ class TmsClientInputPortImpl : public TmsClientComponentBaseImpl<MirroredInputPo
ErrCode INTERFACE_FUNC setRequiresSignal(Bool value) override;

StringPtr onGetRemoteId() const override; // fixme move to protected

SignalPtr getSignalNoLock() override;
protected:
SignalPtr onGetSignal();
SignalPtr onGetSignal() const;
};

END_NAMESPACE_OPENDAQ_OPCUA_TMS
7 changes: 6 additions & 1 deletion shared/libraries/opcuatms/opcuatms_client/src/objects/tms_client_input_port_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ ErrCode TmsClientInputPortImpl::getSignal(ISignal** signal)
return errCode;
}

SignalPtr TmsClientInputPortImpl::onGetSignal()
SignalPtr TmsClientInputPortImpl::onGetSignal() const
{
auto browser = clientContext->getReferenceBrowser();

Expand All @@ -152,6 +152,11 @@ StringPtr TmsClientInputPortImpl::onGetRemoteId() const
return String(remoteComponentId).detach();
}

SignalPtr TmsClientInputPortImpl::getSignalNoLock()
{
return onGetSignal();
}

ErrCode TmsClientInputPortImpl::getConnection(IConnection** connection)
{
return DAQ_MAKE_ERROR_INFO(OPENDAQ_ERR_NOTIMPLEMENTED);
Expand Down
Loading