-
Notifications
You must be signed in to change notification settings - Fork 277
release: Release 2 gems #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Release 2 gems #1907
Conversation
* opentelemetry-api 2.0.0 (was 1.6.0) * opentelemetry-logs-sdk 0.4.0 (was 0.3.0)
|
Removing the @open-telemetry/ruby-maintainers, what do you think? If I haven't heard anything, I'll release Thursday, 4 September. |
|
WARNING: An additional commit was added while this release PR was open. Commit link: 463ef11 Message: The spec states:
With new tests that match the spec, the current implementation fails |
|
WARNING: An additional commit was added while this release PR was open. Commit link: 7f5db11 Message:
Co-authored-by: Kayla Reopelle 87386821+kaylareopelle@users.noreply.github.com |
|
I'm not a huge fan of the bump to 2.0.0. It is technically correct, but I wonder if it would be better to retract (somehow) the API version with the incorrectly added methods? Swift and Javascript recently bumped their versions to 2.0.0, but those appear to contain major changes, including removal of deprecated APIs. Bumping to 2.0.0 feels like a major event, and it would be disappointing to do so "by accident". A particular concern is the API support guarantee required by OpenTelemetry:
3 years is a long time to support a non-spec-conforming API version. |
fbogsany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment. I'd prefer to "retract" the previously released, non-spec-conforming API version and keep the 2.0.0 bump for a true major release.
|
WARNING: An additional commit was added while this release PR was open. Commit link: d8d8f98 Message:
Co-authored-by: Robert robertlaurin@users.noreply.github.com Co-authored-by: Robert robertlaurin@users.noreply.github.com |
|
@fbogsany - sorry for missing the comments on this PR. I'm not sure what our options are to retract. I'll ask around in the OTel space and see if anyone else has an example of that. |
|
WARNING: An additional commit was added while this release PR was open. Commit link: 1f4f85e Message:
Co-authored-by: Kayla Reopelle (she/her) 87386821+kaylareopelle@users.noreply.github.com
Because converting to SCREAMING_SNAKE_CASE cannot distinguish ... and ... So, like other languages, ignore the deprecated messaging.client_id in
Apparently there are some kinks to work out.
There's naming hijinks in the db.* namespace I would like to avoid in
Explain the auto-generated situation.
The v1.10 names whose comments were updated in this commit were renamed Removed test for one-to-one matching of 1.10 constants to 1.25 "all"
Co-authored-by: Kayla Reopelle 87386821+kaylareopelle@users.noreply.github.com
Yard's default use of the rdoc markdown provider was choking on links Let's switch to kramdown which is a markdown parser and
With multiple template entries in weaver.yaml, code generation for
Each root namespace gets separate attributes and metrics files. Include examples of possible values for attributes. Include a usage example of the template attributes as lambdas. Fix links in doc comments referencing stable constants. Co-authored-by: Hannah Ramadan hannahramadan@users.noreply.github.com
Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Minitest/EmptyLineBeforeAssertionMethods: Add empty line before assertion. Co-authored-by: Kayla Reopelle 87386821+kaylareopelle@users.noreply.github.com Co-authored-by: Kayla Reopelle (she/her) 87386821+kaylareopelle@users.noreply.github.com |
|
WARNING: An additional commit was added while this release PR was open. Commit link: 3d82438 Message: Co-authored-by: Kayla Reopelle 87386821+kaylareopelle@users.noreply.github.com |
|
WARNING: An additional commit was added while this release PR was open. Commit link: 75c8a39 Message:
This commit implements the missing isRemote flag functionality in the Ruby Changes:
The implementation follows the exact same pattern as other OpenTelemetry Flag values:
Fixes: Missing span flags support in OTLP exporter
This addresses reviewer feedback that the common.rb file was not the production version.
Addresses reviewer suggestion for cleaner, more explicit function signature.
The .tap method allows us to set the flags field and return the span
This eliminates the need for separate span.flags assignment and makes
This completes the refactoring to pass flags directly in constructors
Co-authored-by: Kayla Reopelle 87386821+kaylareopelle@users.noreply.github.com |
This pull request prepares new gem releases for the following gems:
For each gem, this pull request modifies the gem version and provides an initial changelog entry based on conventional commit messages. You can edit these changes before merging, to release a different version or to alter the changelog text.
The generated changelog entries have been copied below:
opentelemetry-api
v2.0.0 / 2025-08-26
BREAKING CHANGE: Remove Span APIs for attributes and events
FIXED: Remove Span APIs for attributes and events
opentelemetry-logs-sdk
v0.4.0 / 2025-08-26
BREAKING CHANGE: Add OTEL_LOGRECORD_ATTRIBUTE_* env vars. Remove OTEL_LOG_RECORD_ATTRIBUTE_* env vars.
ADDED: Add OTEL_LOGRECORD_ATTRIBUTE_* env vars. Remove OTEL_LOG_RECORD_ATTRIBUTE_* env vars.