-
Notifications
You must be signed in to change notification settings - Fork 786
opentelemetry-sdk: make it possible to customize processors configuration #4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py
Outdated
Show resolved
Hide resolved
…tion Make it easier for distributions to override the processors set up by the sdk configurator by specifying a span processor and a log record processor.
d84b162 to
ba28759
Compare
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py
Outdated
Show resolved
Hide resolved
| ] | ||
|
|
||
|
|
||
| class ExporterSpanProcessorT(Protocol): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this SpanProcessorCustomizerT and everything in this PR Customizer instead ? Or maybe Initializer ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed them _ConfigurationExporterSpanProcessorT and _ConfigurationExporterLogRecordProcessorT so they are less confusing.
Description
Make it easier for distributions to override the processors set up by the sdk configurator by specifying a list of span processors, a list of log record processors and the span and log record processor designated to call the exporters.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: