fix(confluent-kafka): skip recv spans when poll/consume returns no messages#4349
Open
sterchelen wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix(confluent-kafka): skip recv spans when poll/consume returns no messages#4349sterchelen wants to merge 1 commit intoopen-telemetry:mainfrom
sterchelen wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…ssages Matches Java instrumentation behavior: only create a recv span when a message is actually received, avoiding empty spans on idle polls. Fixes open-telemetry#3590
emdneto
reviewed
Mar 20, 2026
| ): | ||
| record = func(*args, **kwargs) | ||
| if record: | ||
| record = func(*args, **kwargs) |
Member
There was a problem hiding this comment.
can you make a test to assert _current_consume_span and _current_context_token are correctly cleaned up on the empty path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Matches Java instrumentation behavior: only create a recv span when a message is actually received, avoiding empty spans on idle polls.
Fixes #3590
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added two new unit tests to cover the empty cases:
test_poll_empty_does_not_create_span: calls poll() on an empty queue twice and asserts no spans are produced
test_consume_empty_does_not_create_span: calls consume() on an empty queue twice and asserts no spans are produced
Existing tests (test_poll, test_consume) were updated to reflect that idle polls/consumes no longer produce recv spans.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.