Reduce boilerplate sprawl for independent release instrumentations#4328
Draft
aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
Reduce boilerplate sprawl for independent release instrumentations#4328aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
aabmass
force-pushed
the
push-rxkunnwlymnz
branch
3 times, most recently
from
aadffea to
47b07d4
Compare
aabmass
force-pushed
the
push-rxkunnwlymnz
branch
from
47b07d4 to
a26c3be
Compare
xrmx
reviewed
Mar 12, 2026
| # RUN `python scripts/generate_instrumentation_bootstrap.py` TO REGENERATE. | ||
|
|
||
| libraries = [ | ||
| { |
Contributor
There was a problem hiding this comment.
Isn't this a breaking change?
| opamp-client-latest: -r {toxinidir}/opamp/opentelemetry-opamp-client/test-requirements.latest.txt | ||
| lint-opamp-client: -r {toxinidir}/opamp/opentelemetry-opamp-client/test-requirements.lowest.txt | ||
|
|
||
| lint-opamp-client: {toxinidir}/opamp/opentelemetry-opamp-client |
| @@ -0,0 +1,13 @@ | |||
| from jinja2 import Environment | |||
Member
Author
There was a problem hiding this comment.
Probably from older attempt
| return sorted(packages, key=lambda p: p["name"]) | ||
|
|
||
|
|
||
| def get_independent_release_packages() -> List[str]: |
Contributor
There was a problem hiding this comment.
We have independently released packages outside genai though and would be great to reuse the same tooling
aabmass
commented
Mar 12, 2026
Comment on lines
-19
to
-26
| { | ||
| "library": "openai >= 1.26.0", | ||
| "instrumentation": "opentelemetry-instrumentation-openai-v2", | ||
| }, | ||
| { | ||
| "library": "google-cloud-aiplatform >= 1.64", | ||
| "instrumentation": "opentelemetry-instrumentation-vertexai>=2.0b0", | ||
| }, |
Member
Author
There was a problem hiding this comment.
This diff shouldn't be here
| @@ -0,0 +1,13 @@ | |||
| from jinja2 import Environment | |||
Member
Author
There was a problem hiding this comment.
Probably from older attempt
| "weaviate-client >= 3.0", | ||
| ] | ||
|
|
||
| [tool.opentelemetry.instrumentation] |
Member
Author
There was a problem hiding this comment.
Lets put the eachdist.ini stuff in here too. That solves the biggest botched release problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.