Skip to content

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Jan 8, 2026

Description

Use the proper attribute per semantic convention for the generation.
Don't break the backward compatibility for now, add a TODO to remove the wrong attribute in following releases.

Spotted by weaver registry live-check, e.g.:

Metric cpython.gc.collected_objects `counter`, `{object}`
    - [improvement] Metric 'cpython.gc.collected_objects' is not stable; stability = development.
    Data point 601
        - [violation] Required attribute 'cpython.gc.generation' is not present.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

xrmx added 2 commits January 8, 2026 09:40
Use the proper attribute per semantic convention for the generation.
Don't break the backward compatibility for now, add a TODO to remove
the wrong attribute in following releases.
@xrmx xrmx requested a review from a team as a code owner January 8, 2026 08:49
@xrmx xrmx moved this to Easy to review / merge / close in @xrmx's Python PR digest Jan 8, 2026
@xrmx xrmx changed the title Fix cpython metrics opentelemetry-instrumentation-system-metrics: fix cpython metrics Jan 8, 2026
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think TODO comment is adequate and noting Breaking Change in future release changelog is sufficient.

@xrmx xrmx merged commit d676efb into open-telemetry:main Jan 9, 2026
663 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in @xrmx's Python PR digest Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants