Skip to content

Remove span attributes pymemcache #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
saurabh-saraswat wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Remove span attributes pymemcache #4076

saurabh-saraswat wants to merge 10 commits into from
+38 −19

Conversation

@saurabh-saraswat
Copy link

@saurabh-saraswat saurabh-saraswat commented Jan 2, 2026 •
edited by xrmx
Loading

Description

Replaces usage of the deprecated SpanAttributes with semconv constants.

Fixes #3475

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ptox run -e $(tox --listenvs | grep memcache | tr '\n' ',')

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 2, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@saurabh-saraswat saurabh-saraswat requested a review from a team as a code owner January 5, 2026 07:01
@emdneto emdneto moved this to Reviewed PRs that need fixes in @xrmx's Python PR digest Jan 6, 2026
@xrmx
Copy link
Contributor

xrmx commented Jan 13, 2026 •
edited
Loading

@saurabh-saraswat Thanks for the PR but in order to contribute to this project you need to sign the CLA

@xrmx xrmx mentioned this pull request Jan 13, 2026
Open
41 tasks
@xrmx xrmx requested a review from herin049 January 20, 2026 10:12
@xrmx xrmx moved this from Reviewed PRs that need fixes to Approved PRs that need fixes in @xrmx's Python PR digest Jan 20, 2026
@xrmx xrmx moved this from Approved PRs that need fixes to Approved PRs in @xrmx's Python PR digest Jan 20, 2026
@xrmx
Copy link
Contributor

xrmx commented Jan 20, 2026

@saurabh-saraswat please pull, tox -e precommit and push the updated files so we can merge this

@xrmx xrmx moved this from Approved PRs to Approved PRs that need fixes in @xrmx's Python PR digest Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@herin049 herin049 Awaiting requested review from herin049

Assignees

No one assigned

Labels

None yet

Projects

@xrmx's Python PR digest
Status: Approved PRs that need fixes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stop using SpanAttributes

3 participants

@saurabh-saraswat @xrmx @herin049