GenAI utils: Add server address, port and additional metric attributes to LLM invocation #4069
+116
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Dec 30, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/metrics.py
Outdated
Show resolved
Hide resolved
lmolkova
commented
Dec 30, 2025
Draft
1 task
xrmx
reviewed
Dec 31, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/metrics.py
Outdated
Show resolved
Hide resolved
util/opentelemetry-util-genai/src/opentelemetry/util/genai/metrics.py
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned
codefromthecrypt,
karthikscale3,
lmolkova,
lzchen and
nirga
JWinermaSplunk
approved these changes
Jan 5, 2026
There was a problem hiding this comment.
Looks good to me! I will admit the first docstring in types.py is a little confusing i.e. saying metric_attributes won't be set on metrics, though I understand it. Also, do we not intend to set server_address or server_port for spans or events based on the second docstring?
Edit: SIG, yes, no address or port for spans, only metrics
wrisa
reviewed
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
server.addressandserver.port(recommended attributes) and ability to provide additional attributes for metrics (needed for OpenAI)