Skip to content

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Dec 29, 2025

Description

Convert usage of deprecated SpanAttributes to semconv constants. Messaging users are not converted since that would require handling the stable messaging semantic convention.

Refs #3475

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner December 29, 2025 16:22
@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Dec 29, 2025
@herin049
Copy link
Contributor

herin049 commented Dec 29, 2025

Looks like you missed some of the messaging attributes in extensions/sns.py and extensions/sqs.py, (e.g. MESSAGING_DESTINATION_NAME) otherwise LGTM

@xrmx
Copy link
Contributor Author

xrmx commented Dec 30, 2025

Looks like you missed some of the messaging attributes in extensions/sns.py and extensions/sqs.py, (e.g. MESSAGING_DESTINATION_NAME) otherwise LGTM

I skipped the messaging ones since it's not possible to do a full conversion without moving to a newer semantic convention.

@xrmx xrmx moved this from Ready for review to Easy to review / merge / close in @xrmx's Python PR digest Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Easy to review / merge / close

Development

Successfully merging this pull request may close these issues.

4 participants