feat: Allow configuring of min/max in histograms#8095
Open
MikeGoldsmith wants to merge 4 commits intoopen-telemetry:mainfrom
Open
feat: Allow configuring of min/max in histograms#8095MikeGoldsmith wants to merge 4 commits intoopen-telemetry:mainfrom
MikeGoldsmith wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
Supports disabling min/max recording to work around GCP min/max handling issues. Backward compatible - defaults to true.
Verifies min/max not tracked when disabled.
9caaa69 to
8f364a5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8095 +/- ##
============================================
- Coverage 90.21% 90.20% -0.02%
- Complexity 7606 7612 +6
============================================
Files 841 841
Lines 22923 22949 +26
Branches 2291 2304 +13
============================================
+ Hits 20680 20700 +20
- Misses 1526 1527 +1
- Partials 717 722 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
recordMinMaxparameter to histogram aggregations per OpenTelemetry spec.Fixes #7859
Motivation
Some users need ability to disable min/max recording in histograms. The OpenTelemetry spec requires this parameter for both explicit and exponential histogram aggregations.
Changes
recordMinMaxparameter toAggregation.explicitBucketHistogram()andAggregation.base2ExponentialBucketHistogram()record_min_maxfrom YAML to SDKrecordMinMax=trueAggregationFactoryextractsrecord_min_maxfrom model and passes to SDK (defaults to true when null)Testing
DoubleExplicitBucketHistogramAggregatorTest.testRecordMinMaxDisabled- verifies min/max not tracked when disabled for explicit histogramsDoubleBase2ExponentialHistogramAggregatorTest.testRecordMinMaxDisabled- verifies min/max not tracked when disabled for exponential histograms