JDBC url parsing for Amazon Aurora#18831
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the JDBC URL parser for AWS Aurora DSQL’s JDBC wrapper URLs (jdbc:aws-dsql:postgresql://...) by stripping the wrapper prefix so parsing delegates to the existing PostgreSQL URL parser. This aligns Aurora DSQL URLs with standard Postgres parsing so db.system and db.name are populated consistently (restoring expected JDBC span naming behavior).
Changes:
- Teach
JdbcConnectionUrlParser.stripJdbcPrefixto unwrapjdbc:aws-dsql:URLs. - Add parameterized tests covering Aurora DSQL URL shapes (with/without explicit port, with user query param).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java | Adds jdbc:aws-dsql: wrapper stripping so URLs are parsed as standard PostgreSQL. |
| instrumentation/jdbc/library/src/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java | Adds new parameterized test cases validating correct parsing of Aurora DSQL JDBC URLs. |
jaydeluca
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #18825
As suggested in #18825 just stripping the prefix and let postgres, mysql and mariadb parsers handle the rest.