Skip to content

JDBC url parsing for Amazon Aurora#18831

Merged
trask merged 3 commits into
open-telemetry:mainfrom
laurit:amazon-aurora-dsql
May 26, 2026
Merged

JDBC url parsing for Amazon Aurora#18831
trask merged 3 commits into
open-telemetry:mainfrom
laurit:amazon-aurora-dsql

Conversation

@laurit
Copy link
Copy Markdown
Contributor

@laurit laurit commented May 22, 2026

Resolves #18825
As suggested in #18825 just stripping the prefix and let postgres, mysql and mariadb parsers handle the rest.

@laurit laurit requested a review from a team as a code owner May 22, 2026 10:16
Copilot AI review requested due to automatic review settings May 22, 2026 10:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the JDBC URL parser for AWS Aurora DSQL’s JDBC wrapper URLs (jdbc:aws-dsql:postgresql://...) by stripping the wrapper prefix so parsing delegates to the existing PostgreSQL URL parser. This aligns Aurora DSQL URLs with standard Postgres parsing so db.system and db.name are populated consistently (restoring expected JDBC span naming behavior).

Changes:

  • Teach JdbcConnectionUrlParser.stripJdbcPrefix to unwrap jdbc:aws-dsql: URLs.
  • Add parameterized tests covering Aurora DSQL URL shapes (with/without explicit port, with user query param).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java Adds jdbc:aws-dsql: wrapper stripping so URLs are parsed as standard PostgreSQL.
instrumentation/jdbc/library/src/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java Adds new parameterized test cases validating correct parsing of Aurora DSQL JDBC URLs.

@laurit laurit changed the title JDBC url parsing for Amazon Aurora DSQL JDBC url parsing for Amazon Aurora May 22, 2026
@laurit laurit added this to the v2.29.0 milestone May 26, 2026
@trask trask merged commit 4bb6468 into open-telemetry:main May 26, 2026
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recognize jdbc:aws-dsql:postgresql:// URLs from the AWS Aurora DSQL JDBC Connector

4 participants