Rename Akka and Scala forkjoin modules#18772
Open
trask wants to merge 1 commit into
Open
Conversation
trask
force-pushed
the
package-name-cleanup-forkjoin-module-names
branch
from
e254391 to
d5561e5
Compare
trask
force-pushed
the
package-name-cleanup-forkjoin-module-names
branch
from
d5561e5 to
20934dd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the Akka and Scala fork-join instrumentation modules to use forkjoin naming, aligning Gradle project paths, instrumentation names, docs, and related tooling references.
Changes:
- Renames Gradle project includes and dependency references for Akka/Scala forkjoin modules.
- Updates Java package names and instrumentation module names while preserving deprecated aliases.
- Updates docs, suppression-list audit tests, FOSSA targets, and suppression-key validation logic.
Reviewed changes
Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
settings.gradle.kts |
Updates included Gradle project paths for renamed modules. |
instrumentation/scala-forkjoin-2.8/metadata.yaml |
Adds metadata for the renamed Scala module. |
instrumentation/scala-forkjoin-2.8/javaagent/build.gradle.kts |
Adds Gradle configuration for the renamed Scala module. |
instrumentation/scala-forkjoin-2.8/javaagent/src/main/java/.../VirtualFields.java |
Updates Scala package name. |
instrumentation/scala-forkjoin-2.8/javaagent/src/main/java/.../ScalaForkJoinTaskInstrumentation.java |
Updates Scala package/import references. |
instrumentation/scala-forkjoin-2.8/javaagent/src/main/java/.../ScalaForkJoinPoolInstrumentation.java |
Updates Scala package/import references. |
instrumentation/scala-forkjoin-2.8/javaagent/src/main/java/.../ScalaConcurrentInstrumentationModule.java |
Renames instrumentation names and adds deprecated aliases. |
instrumentation/akka/akka-http-10.0/javaagent/build.gradle.kts |
Updates test instrumentation dependencies to renamed modules. |
instrumentation/akka/akka-actor-forkjoin-2.5/javaagent/build.gradle.kts |
Adds Gradle configuration for the renamed Akka module. |
instrumentation/akka/akka-actor-forkjoin-2.5/javaagent/src/main/java/.../VirtualFields.java |
Updates Akka package name. |
instrumentation/akka/akka-actor-forkjoin-2.5/javaagent/src/main/java/.../AkkaForkJoinTaskInstrumentation.java |
Updates Akka package name. |
instrumentation/akka/akka-actor-forkjoin-2.5/javaagent/src/main/java/.../AkkaForkJoinPoolInstrumentation.java |
Updates Akka package name. |
instrumentation/akka/akka-actor-forkjoin-2.5/javaagent/src/main/java/.../AkkaActorForkJoinInstrumentationModule.java |
Renames instrumentation names and adds deprecated aliases. |
instrumentation/akka/akka-actor-forkjoin-2.5/javaagent/src/test/java/.../AkkaExecutorInstrumentationTest.java |
Updates Akka test package name. |
instrumentation/akka/akka-actor-forkjoin-2.5/javaagent/src/test/java/.../AkkaAsyncChild.java |
Updates Akka test package name. |
instrumentation-docs/src/main/java/.../SuppressionListAuditor.java |
Updates suppression override key for renamed Akka module. |
instrumentation-docs/src/test/java/.../SuppressionListAuditorTest.java |
Updates expected instrumentation-list names and paths. |
docs/instrumentation-list.yaml |
Updates generated instrumentation list entries for renamed modules. |
docs/contributing/documenting-instrumentation.md |
Updates documentation example naming. |
.github/scripts/check-javaagent-suppression-keys.sh |
Allows deprecated-name expansion in suppression-key checks. |
.fossa.yml |
Updates FOSSA Gradle targets for renamed modules. |
| include(":instrumentation:rxjava:rxjava-common-3.0:library") | ||
| include(":instrumentation:rxjava:rxjava-common-3.0:testing") | ||
| include(":instrumentation:scala-fork-join-2.8:javaagent") | ||
| include(":instrumentation:scala-forkjoin-2.8:javaagent") |
| features: | ||
| - CONTEXT_PROPAGATION | ||
| source_path: instrumentation/akka/akka-actor-fork-join-2.5 | ||
| source_path: instrumentation/akka/akka-actor-forkjoin-2.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of