Module cleanup: batch of 6 modules (run 25845244718)#18741
Closed
otelbot-java-instrumentation[bot] wants to merge 7 commits into
Closed
Module cleanup: batch of 6 modules (run 25845244718)#18741otelbot-java-instrumentation[bot] wants to merge 7 commits into
otelbot-java-instrumentation[bot] wants to merge 7 commits into
Conversation
- Inline non-semconv `state` AttributeKey constant in AbstractSystemMetricsTest; replace class-level `private static final` field with inline `stringKey("state")` calls per testing-general-patterns.md rule that non-semconv keys must not be extracted into constants
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove static import of updateSpan from Play26Singletons; use qualified call instead, since updateSpan is a verb-named helper that performs work and is not a singleton accessor Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace static AutoCleanupExtension with plain @afterall in PlayWsClientBaseTest and all subclasses to fix cleanup leaks when multiple subclasses run in the same JVM fork Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Reduce visibility of PulsarNetClientAttributesGetter from public to package-private (final class); it is only instantiated within the same telemetry package and is not directly referenced from any advice method Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add @nullable to normalize() uriTemplate parameter since callers pass potentially-null values from target.getClassPath() and target.getPath() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Convert static container and port fields to instance fields to align with @testinstance(PER_CLASS) lifecycle, preventing cross-subclass state sharing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
Closing in favor of #18750 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated module-cleanup batch.
Modules in this batch
oshi:testingplay-mvc-2.6:javaagentplay-ws-common-1.0:testingpulsar-2.8:javaagentquarkus-resteasy-reactive:javaagentr2dbc-1.0:testingCleanup for oshi:testing
stateAttributeKey constant in AbstractSystemMetricsTest; replace class-levelprivate static finalfield with inlinestringKey("state")calls per testing-general-patterns.md rule that non-semconv keys must not be extracted into constantsCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Cleanup for play-mvc-2.6:javaagent
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Cleanup for play-ws-common-1.0:testing
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Cleanup for pulsar-2.8:javaagent
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Cleanup for quarkus-resteasy-reactive:javaagent
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Cleanup for r2dbc-1.0:testing
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com