Add HTTP/2 test coverage for Armeria server instrumentation#18737
Open
bhawnapannu2701 wants to merge 2 commits into
Open
Add HTTP/2 test coverage for Armeria server instrumentation#18737bhawnapannu2701 wants to merge 2 commits into
bhawnapannu2701 wants to merge 2 commits into
Conversation
Contributor
|
This PR doesn't contain any changed files. We already have http2 tests for armeria https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/armeria/armeria-1.3/library/src/test/java/io/opentelemetry/instrumentation/armeria/v1_3/ArmeriaHttp2ServerTest.java |
laurit
added
the
needs author feedback
Contributor
|
This PR has been labeled as stale due to lack of activity and needing author feedback. It will be automatically closed if there is no further activity over the next 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #3227 tracks adding HTTP/2 coverage for HTTP instrumentation. Armeria server library instrumentation currently runs the shared HTTP server tests in the default HTTP/1.1 mode only.
Fix
Adds ArmeriaHttp2ServerTest, which extends the existing ArmeriaHttpServerTest and enables HttpServerTestOptions.useHttp2(). This reuses the existing shared HTTP server test suite and exercises the same Armeria library instrumentation over h2c.
Tests
Risks
Low. This is a test-only change and does not change production instrumentation behavior.
How to verify
Run the focused Armeria HTTP/2 test task above and confirm the inherited server tests pass with HTTP/2 enabled.
Fixes #3227