[wip] remove getModuleGroup#18707
Draft
SylvainJuge wants to merge 26 commits into
Draft
Conversation
JonasKunz
reviewed
May 18, 2026
Contributor
JonasKunz
left a comment
There was a problem hiding this comment.
Overall approach makes sense to me!
This approach allows to put the shared classes in a library, which can be shared across the modules to make the dependencies explicit.
One suggestion I would have is to maybe not use *.common, but something more obscure like otel_common. Thanks to indy, Instrumentation modules can use libraries/dependencies without polluting the instrumented classpath. The *.common package name pattern could be coincidentally used in those libraries, while for something like otel_common this won't happen.
…nstrumentation into cl-annotation
…nstrumentation into module-group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress draft to remove
getModuleGroup.Fixes #17720
Summary
InstrumentationModuleClassLoaderinstance for each instrumented classloaderpackage-info.java+ annotation to indicate using common classloaderpackage-info.javafor all packages in libraries, hence making them loaded in the common CL. keeping this manual could also be fine as not all libraries are shared.*.common.*but that sounds brittle and sensitive to minor inconsistencies in package names.Step 1: verify we can rely on hard-coded package name.
Step 2: implement a long-term solution