Fix: Suppress deprecated warnings in generated semconv metric headers#4088
Open
RaviTriv wants to merge 2 commits into
Open
Fix: Suppress deprecated warnings in generated semconv metric headers#4088RaviTriv wants to merge 2 commits into
RaviTriv wants to merge 2 commits into
Conversation
|
|
RaviTriv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3986
Changes
Attempting fix for issue 3986, deprecation warnings reported from metrics_foo_library example.
When some of the semconv generated headers are included, deprecated warnings for functions are produced even if the function is not used. This occurs because the function uses deprecated variables in its body. That's triggers
-Wdeprecated-declarationsand since these helpers arestatic inlinein a header, every file that includes the header gets the warning. This PR proposes adding new macros,OPENTELEMETRY_SUPPRESS_DEPRECATED_BEGINandOPENTELEMETRY_SUPPRESS_DEPRECATED_ENDto manually wrap these deprecated variables in the generator.Appreciate time and effort for review. Happy to discuss / update to a more approriate solution.
Thank you :)
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes