Skip to content

Edit dampers and psds#381

Merged
vitorslongo merged 107 commits intodevfrom
edit_dampers_and_psds
Apr 6, 2026
Merged

Edit dampers and psds#381
vitorslongo merged 107 commits intodevfrom
edit_dampers_and_psds

Conversation

@vitorslongo
Copy link
Copy Markdown
Collaborator

@vitorslongo vitorslongo commented Mar 12, 2026

This PR adds the requested functionality to edit and copy dampers in the project.
Also, the changes were also applied to PSDs because the workflow is basically the same.

Closes: #376

@vitorslongo
Copy link
Copy Markdown
Collaborator Author

Both the Copy and Edit methods have a problem where they end up removing the damper label from the damper lines properties in the line_properties file (or something along those lines).
You can see this by selecting a damper, clicking “Edit” or “Copy”, then closing the window.
When you reopen the damper editor and check the Lines column, the list is empty for the damper you selected.

I’ve tried several possible solutions, but none of them worked. Since you’ve worked with this file-writing logic before, could you give me a hand here, @JacsonGilVargas?

@vitorslongo vitorslongo self-assigned this Mar 12, 2026
@vitorslongo vitorslongo added Feature request 🙏 New feature or request Nice to have 💡 Ideas that have lower priority, but are nice to have labels Mar 13, 2026
@vitorslongo
Copy link
Copy Markdown
Collaborator Author

vitorslongo commented Mar 22, 2026

Both the Copy and Edit methods have a problem where they end up removing the damper label from the damper lines properties in the line_properties file (or something along those lines). You can see this by selecting a damper, clicking “Edit” or “Copy”, then closing the window. When you reopen the damper editor and check the Lines column, the list is empty for the damper you selected.

I’ve tried several possible solutions, but none of them worked. Since you’ve worked with this file-writing logic before, could you give me a hand here, @JacsonGilVargas?

This bug was solved in #0b1ff2c. Basically, the damper info was not being written in the export file, a critical problem way beyond the copy and edit methods.

It is solved now, therefore, @JacsonGilVargas, you can conduct the tests normally now and see if you approve the copy and edit methods. If everything is ok I'll go ahead and make the same changes to the PSD editor.

@vitorslongo vitorslongo marked this pull request as ready for review March 22, 2026 19:40
@vitorslongo
Copy link
Copy Markdown
Collaborator Author

All the changes planned for this PR are implemented. It is now complete and ready for review and subsequent merging.

JacsonGilVargas and others added 22 commits April 2, 2026 11:40
…ries_in_json_format

Improvements in fluid and material classes
Copy link
Copy Markdown
Collaborator

@JacsonGilVargas JacsonGilVargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like everything is working perfectly. Excellent features and code improvements, @vitorslongo.

@vitorslongo vitorslongo merged commit 1951187 into dev Apr 6, 2026
1 check passed
@vitorslongo vitorslongo deleted the edit_dampers_and_psds branch April 6, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature request 🙏 New feature or request Nice to have 💡 Ideas that have lower priority, but are nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants