Conversation
|
Both the Copy and Edit methods have a problem where they end up removing the damper label from the damper lines properties in the line_properties file (or something along those lines). I’ve tried several possible solutions, but none of them worked. Since you’ve worked with this file-writing logic before, could you give me a hand here, @JacsonGilVargas? |
This bug was solved in #0b1ff2c. Basically, the damper info was not being written in the export file, a critical problem way beyond the copy and edit methods. It is solved now, therefore, @JacsonGilVargas, you can conduct the tests normally now and see if you approve the copy and edit methods. If everything is ok I'll go ahead and make the same changes to the PSD editor. |
|
All the changes planned for this PR are implemented. It is now complete and ready for review and subsequent merging. |
…raries_in_json_format
…tps://github.com/open-pulse/OpenPulse into save_fluid_and_material_libraries_in_json_format
…rors when plotting compressor data.
…ries_in_json_format Improvements in fluid and material classes
JacsonGilVargas
left a comment
There was a problem hiding this comment.
It seems like everything is working perfectly. Excellent features and code improvements, @vitorslongo.
This PR adds the requested functionality to edit and copy dampers in the project.
Also, the changes were also applied to PSDs because the workflow is basically the same.
Closes: #376