Skip to content

Se realizan cambios a la libreria para el envio de un nuevo parametro… #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlos-galvan-openpay wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Se realizan cambios a la libreria para el envio de un nuevo parametro… #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Full API documentation available at http://docs.openpay.mx/.
//class
var Openpay = require('openpay');
//instantiation
var openpay = new Openpay(' your merchant id ', ' your private key ', [ isProduction ]);
var openpay = new Openpay(' your merchant id ', ' your private key ','public IP address of the client',"mx", [ isProduction ]);
//use the api
openpay.< resource_name >.< method_name >( ... )
```
Expand Down Expand Up @@ -92,7 +92,7 @@ Before use the library will be necessary to set up your Merchant ID and Private

```js
var Openpay = require('openpay');
var openpay = new Openpay('your merchant id', 'your private key', 'mx', false);
var openpay = new Openpay('your merchant id', 'your private key','public IP address of the client', 'mx', false);
openpay.setTimeout(30000);
```

Expand All @@ -102,6 +102,7 @@ In addition, you can set the merchant id, private key, and the mode like this
openpay.setMerchantId(' your merchant id ');
openpay.setPrivateKey(' your private key ');
openpay.setProductionReady(true)
openpay.setPublicIp('138.84.62.109')
```

Once configured the library, you can use it to interact with Openpay API services.
Expand Down
26 changes: 21 additions & 5 deletions lib/openpay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,21 @@ Openpay.SANDBOX_URL = 'https://sandbox-api.openpay.mx';
Openpay.SANDBOX_API_VERSION = '/v1/';


function Openpay(merchantId, privateKey, countryCode = 'mx', isProductionReady) {
function Openpay(merchantId, privateKey, publicIp, countryCode = 'mx', isProductionReady) {
if (!publicIp) {
throw new Error("Public Ip can't be null or empty");
}
this.merchantId = merchantId;
this.privateKey = privateKey;
this.isSandbox = isProductionReady ? false : true;
this.timeout = 90000;
this.publicIp = publicIp;
this.define({
isSandbox: this.isSandbox,
privateKey: this.privateKey,
merchantId: this.merchantId,
timeout: this.timeout
timeout: this.timeout,
publicIp: this.publicIp,
});
this.setBaseUrl(countryCode);

Expand All @@ -30,6 +35,10 @@ function Openpay(merchantId, privateKey, countryCode = 'mx', isProductionReady)
this.privateKey = privateKey;
this._reDefine();
};
this.setPublicIp = function (publicIp) {
this.publicIp = publicIp;
this._reDefine();
};

this.setProductionReady = function (isProductionReady) {
this.isSandbox = !isProductionReady;
Expand All @@ -46,7 +55,8 @@ function Openpay(merchantId, privateKey, countryCode = 'mx', isProductionReady)
isSandbox: this.isSandbox,
privateKey: this.privateKey,
merchantId: this.merchantId,
timeout: this.timeout
timeout: this.timeout,
publicIp:this.publicIp
});
};
}
Expand Down Expand Up @@ -956,7 +966,10 @@ var sendRequest = function (data) {
contentType: 'json',
timeout: data.timeout,
data: data.requestData.json,
dataType: 'json'
dataType: 'json',
headers: {
'X-Forwarded-For': data.publicIp
}
};

urllib.request(url, options, function (err, body, res) {
Expand All @@ -975,7 +988,10 @@ var sendStoreRequest = function (data) {
contentType: 'json',
timeout: data.timeout,
data: data.requestData.json,
dataType: 'json'
dataType: 'json',
headers: {
'X-Forwarded-For': data.publicIp
}
};

urllib.request(url, options, function (err, body, res) {
Expand Down
2 changes: 1 addition & 1 deletion test/bank-accounts.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var assert = require('assert');
var _ = require('underscore');
var Openpay = require('../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905');
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905',"138.85.61.94");
openpay.setTimeout(20000);
var enableLogging = true;
var customerId = '';
Expand Down
2 changes: 1 addition & 1 deletion test/cards.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905');
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905',"138.85.61.94");
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
2 changes: 1 addition & 1 deletion test/charges_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905');
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905',"138.85.61.94");
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
2 changes: 1 addition & 1 deletion test/colombia/cards.test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
2 changes: 1 addition & 1 deletion test/colombia/charges_test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
2 changes: 1 addition & 1 deletion test/colombia/clients_test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(10000);
var enableLogging = true;

Expand Down
7 changes: 4 additions & 3 deletions test/colombia/plans.test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(20000);
var enableLogging = true;

Expand All @@ -14,7 +14,8 @@ var newPlan = {
"name": "Curso de ingles",
"repeat_unit": "month",
"trial_days": "30",
"repeat_every": "1"
"repeat_every": "1",
"currency":"COP",
}
describe('Plans testing', function () {
var plan;
Expand All @@ -30,7 +31,7 @@ describe('Plans testing', function () {

describe('Update plan', function () {
it('should return statusCode 200||201', function (done) {
const updatePlan = {name:"plan updated"}
const updatePlan = {name:"plan updated"};
openpay.plans.update(plan.id, updatePlan, function (error, body, response) {
assert.equal(response.statusCode === 200 || response.statusCode === 201, true, '');
done();
Expand Down
2 changes: 1 addition & 1 deletion test/colombia/pse_test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
18 changes: 9 additions & 9 deletions test/colombia/subscriptions.test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var assert = require('assert');
var _ = require('underscore');
var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down Expand Up @@ -40,7 +40,7 @@ describe('Plans testing', function () {
var customer;
var subscription;

describe('Create plan', function () {
it('Create plan', function () {
it('should return statusCode 200||201', function (done) {
openpay.plans.create(newPlan, function (error, body, response) {
plan = body;
Expand All @@ -50,7 +50,7 @@ describe('Plans testing', function () {
});
});

describe('Create customer', function () {
it('Create customer', function () {
it('create customer for test', function (done) {
openpay.customers.create(testCreateCustomer, function (error, body, response) {
customer = body;
Expand All @@ -60,9 +60,9 @@ describe('Plans testing', function () {
});


describe('Create subscription', function () {
subscription.plan_id = plan?.id;
it('Create subscription', function () {
it('should return statusCode 200||201', function (done) {
subscription.plan_id = plan.id;
openpay.customers.subscriptions.create(customer.id, subscription, function (error, body, response) {
subscription = body;
assert.equal(response.statusCode === 200 || response.statusCode === 201, true, '');
Expand All @@ -71,7 +71,7 @@ describe('Plans testing', function () {
});
});

describe('Update subscription', function () {
it('Update subscription', function () {
it('should return statusCode 200||201', function (done) {
const updateSubscription = {trial_end_date: "2021-12-12"}
openpay.customers.subscriptions.update(subscription.id, updateSubscription, function (error, body, response) {
Expand All @@ -81,7 +81,7 @@ describe('Plans testing', function () {
});
});

describe('Get subscription', function () {
it('Get subscription', function () {
it('should return statusCode 200||201', function (done) {
openpay.customers.subscriptions.get(customer.id, subscription.id, function (error, body, response) {
assert.equal(response.statusCode === 200 || response.statusCode === 201, true, '');
Expand All @@ -91,7 +91,7 @@ describe('Plans testing', function () {
});


describe('subscription List', function () {
it('subscription List', function () {
it('should return statusCode 200||201', function (done) {
var searchParams = {
'limit': 10
Expand All @@ -103,7 +103,7 @@ describe('Plans testing', function () {
});
});

describe('Cancell subscription', function () {
it('Cancell subscription', function () {
it('should return statusCode 200||201', function (done) {
openpay.customers.subscriptions.delete(subscription.id, function (error, body, response) {
assert.equal(response.statusCode === 200 || response.statusCode === 201 || response.statusCode === 204, true, '');
Expand Down
2 changes: 1 addition & 1 deletion test/colombia/tokens_test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(20000);
var enableLogging = true;

Expand Down
4 changes: 2 additions & 2 deletions test/colombia/webhooks_test.colombia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a', 'co', false);
var openpay = new Openpay('mwf7x79goz7afkdbuyqd', 'sk_94a89308b4d7469cbda762c4b392152a',"138.85.61.94", 'co', false);
openpay.setTimeout(20000);
var enableLogging = true;

const newWebhook = {
"url": "https://webhook.site/ab854ec2-2ac1-423b-9c0b-8502fd056cc9",
"url": "https://webhook.site/fbabe962-95c5-475c-9925-9f769ac3bc7e",
"user": "juanito",
"password": "passjuanito",
"event_types": [
Expand Down
2 changes: 1 addition & 1 deletion test/customers_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('gdntnaxvkcdviesgaxem', 'sk_b97e606487d34b44ab66e03d5bd14747');
var openpay = new Openpay('gdntnaxvkcdviesgaxem', 'sk_b97e606487d34b44ab66e03d5bd14747',"138.85.61.94");
openpay.setTimeout(10000);
var enableLogging = true;

Expand Down
2 changes: 1 addition & 1 deletion test/fees.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905');
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905',"138.85.61.94");
openpay.setTimeout(2000);
var enableLogging = true;

Expand Down
4 changes: 2 additions & 2 deletions test/group_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var urllib = require('urllib');

var Openpay = require('../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('gdntnaxvkcdviesgaxem', 'sk_b97e606487d34b44ab66e03d5bd14747');
var openpay = new Openpay('gdntnaxvkcdviesgaxem', 'sk_b97e606487d34b44ab66e03d5bd14747',"138.85.61.94");
openpay.setTimeout(10000);

var enableLogging = true;
Expand Down Expand Up @@ -278,7 +278,7 @@ describe('Testing group API', function(){
});
describe('Update subscription', function(){
it('should return statusCode 200', function (done){
openpay.groups.customers.subscriptions.update(merchantId, newlyCreatedCustomerId, newlyCreatedSubscriptionId, {"trial_end_date": "2022-02-11"}, function (error, body, response){
openpay.groups.customers.subscriptions.update(merchantId, newlyCreatedCustomerId, newlyCreatedSubscriptionId, {"trial_end_date": "2025-02-11"}, function (error, body, response){
printLog(response.statusCode, body, error);
assert.equal(response.statusCode, 200, '');
done();
Expand Down
2 changes: 1 addition & 1 deletion test/payouts_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905');
var openpay = new Openpay('m1qp3av1ymcfufkuuoah', 'sk_ed05f1de65fa4a67a3d3056a4efa2905',"138.85.61.94");
openpay.setTimeout(20000);
var enableLogging = true;

Expand Down
4 changes: 2 additions & 2 deletions test/peru/cards.pe.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', 'pe',false);
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', "138.84.62.90",'pe',false);
openpay.setTimeout(30000);
var enableLogging = true;
const card = {
Expand Down Expand Up @@ -137,7 +137,7 @@ describe('get cards', function () {
describe('delete card', function () {
it('create customer', function (done) {
var searchParams = {
'creation[gte]': '2021-01-01',
'creation[gte]': '2024-09-03',
'limit': 1
};
openpay.customers.list(searchParams, function (error, body, response) {
Expand Down
2 changes: 1 addition & 1 deletion test/peru/charges.pe.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', 'pe',false);
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', "138.85.61.94",'pe',false);
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
2 changes: 1 addition & 1 deletion test/peru/checkouts.pe.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', 'pe',false);
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', "138.85.61.94",'pe',false);
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
2 changes: 1 addition & 1 deletion test/peru/customers.pe.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', 'pe',false);
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', "138.85.61.94",'pe',false);
openpay.setTimeout(10000);
var enableLogging = true;
const customer = {
Expand Down
2 changes: 1 addition & 1 deletion test/peru/tokens.pe.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', 'pe',false);
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', "138.85.61.94",'pe',false);
openpay.setTimeout(30000);
var enableLogging = true;

Expand Down
4 changes: 2 additions & 2 deletions test/peru/webhooks.pe.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ var _ = require('underscore');

var Openpay = require('../../lib/openpay');
/*Sandbox*/
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', 'pe',false);
var openpay = new Openpay('m3cji4ughukthjcsglv0', 'sk_f934dfe51645483e82106301d985a4f6', "138.85.61.94",'pe',false);
openpay.setTimeout(30000);
var enableLogging = true;
const webhook = {
"url": "https://webhook.site/dffe8335-b0bb-493f-a38d-3e61b711bd6a", // Cambiar por URL válida
"url": "https://webhook.site/fbabe962-95c5-475c-9925-9f769ac3bc7e", // Cambiar por URL válida
"user": "juanito",
"password": "passjuanito",
"event_types": [
Expand Down
Loading